On Thu, 13 Jun 2024 17:36:16 +0200 Larysa Zaremba wrote: > > > AFAIK, netif_device_detach() does not affect .ndo_bpf() calls. We were trying > > > such approach with idpf and it does work for ethtool, but not for XDP. > > > > I reckon that's an unintentional omission. In theory XDP is "pure > > software" but if the device is running driver will likely have to > > touch HW to reconfigure. So, if you're willing, do send a ndo_bpf > > patch to add a detached check. > > This does not seem that simple. In cases of program/pool detachment, > .ndo_bpf() does not accept 'no' as an answer, so there is no easy existing way > of handling !netif_device_present() either. And we have to notify the driver > that pool/program is no longer needed no matter what. So what is left is somehow > postpone pool/prog removal to after the netdev gets attached again. I see, thanks for investigating!
