On Mon, Dec 9, 2019 at 11:17 AM Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: > > Hello! > > On 09.12.2019 10:56, Magnus Karlsson wrote: > > > In the xsk consumer ring code there is a variable call RX_BATCH_SIZE > > Called? Yes, definitely. Will fix. Thanks: Magnus > > that dictates the minimum number of entries that we try to grab from > > the fill and Tx rings. In fact, the code always try to grab the > ^^^^^^^^^^^^^^^^^^^^^ hm, are you sure there's no typo here? > > > maximum amount of entries from these rings. The only thing this > > variable does is to throw an error if there is less than 16 (as it is > > defined) entries on the ring. There is no reason to do this and it > > will just lead to weird behavior from user space's point of view. So > > eliminate this variable. > > > > With this change, we will be able to simplify the xskq_nb_free and > > xskq_nb_avail code in the next commit. > > > > Signed-off-by: Magnus Karlsson <magnus.karlsson@xxxxxxxxx> > [...] > > MBR, Sergei >
