Re: [PATCH bpf-next 05/12] xsk: eliminate the RX batch size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello!

On 09.12.2019 10:56, Magnus Karlsson wrote:

In the xsk consumer ring code there is a variable call RX_BATCH_SIZE

   Called?

that dictates the minimum number of entries that we try to grab from
the fill and Tx rings. In fact, the code always try to grab the
  ^^^^^^^^^^^^^^^^^^^^^ hm, are you sure there's no typo here?

maximum amount of entries from these rings. The only thing this
variable does is to throw an error if there is less than 16 (as it is
defined) entries on the ring. There is no reason to do this and it
will just lead to weird behavior from user space's point of view. So
eliminate this variable.

With this change, we will be able to simplify the xskq_nb_free and
xskq_nb_avail code in the next commit.

Signed-off-by: Magnus Karlsson <magnus.karlsson@xxxxxxxxx>
[...]

MBR, Sergei




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux