Re: [PATCH bpf-next] selftests/bpf: extend uprobe/uretprobe triggering benchmarks

[Daniel Borkmann <daniel@xxxxxxxxxxxxx>]

On 3/1/24 10:45 PM, Andrii Nakryiko wrote:
[...]
> diff --git a/tools/testing/selftests/bpf/benchs/bench_trigger.c b/tools/testing/selftests/bpf/benchs/bench_trigger.c
> index dbd362771d6a..a8ed8afff0b3 100644
> --- a/tools/testing/selftests/bpf/benchs/bench_trigger.c
> +++ b/tools/testing/selftests/bpf/benchs/bench_trigger.c
> @@ -113,12 +113,25 @@ static void trigger_fmodret_setup(void)
>    * GCC doesn't generate stack setup preample for these functions due to them
>    * having no input arguments and doing nothing in the body.
>    */
> -__weak void uprobe_target_with_nop(void)
> +__weak void uprobe_target_nop(void)
>   {
>   	asm volatile ("nop");
>   }
>   
> -__weak void uprobe_target_without_nop(void)
> +__weak void opaque_noop_func()
> +{
> +}

Nice work and super useful to have! I fixed up the void while applying.

Thanks,
Daniel