On Mon, Feb 12, 2024 at 1:56 AM Hari Bathini <hbathini@xxxxxxxxxxxxx> wrote:
>
>
>
> On 09/02/24 1:26 am, Stanislav Fomichev wrote:
> > On 02/08, Hari Bathini wrote:
> >> Compiling with CONFIG_BPF_SYSCALL & !CONFIG_BPF_JIT throws the below
> >> warning:
> >>
> >> "WARN: resolve_btfids: unresolved symbol bpf_cpumask"
> >>
> >> Fix it by adding the appropriate #ifdef.
> >
> > Can you explain a bit more on why CONFIG_BPF_JIT is appropriate here?
> > kernel/bpf/cpumask.c seems to be gated by CONFIG_BPF_SYSCALL.
> > So presumably all those symbols should be still compiled in with !CONFIG_BPF_JIT?
>
> Actually, CONFIG_BPF_JIT is the precondition for cpumask.c
> where bpf_cpumask structure is defined.
>
> ifeq ($(CONFIG_BPF_JIT),y)
> obj-$(CONFIG_BPF_SYSCALL) += bpf_struct_ops.o
> obj-$(CONFIG_BPF_SYSCALL) += cpumask.o
> obj-${CONFIG_BPF_LSM} += bpf_lsm.o
> endif
Ah, good point!
Acked-by: Stanislav Fomichev <sdf@xxxxxxxxxx>
