On Wed, 31 Jan 2024 16:32:00 +0100 Toke Høiland-Jørgensen wrote: > > ack from my side if you have some use-cases in mind. > > Some questions below: > > - can we assume ethtool will be used to report stats just for 'global' > > page_pool (not per-cpu page_pool)? > > - can we assume netlink/yaml will be used to report per-cpu page_pool stats? > > > > I think in the current series we can fix the accounting part (in particular > > avoiding memory wasting) and then we will figure out how to report percpu > > page_pool stats through netlink/yaml. Agree? > > Deferring the export API to a separate series after this is merged is > fine with me. +1 > In which case the *gathering* of statistics could also be > deferred (it's not really useful if it can't be exported). What do you mean by "gather" here? If we plan to expose them later on I reckon there's no point having this patch which actively optimizes them away, no? IOW we should just drop this patch from v7?
