> On 2024/1/29 21:07, Lorenzo Bianconi wrote: > >> On 2024/1/28 22:20, Lorenzo Bianconi wrote: > >>> Move page_pool stats allocation in page_pool_create routine and get rid > >>> of it for percpu page_pools. > >> > >> Is there any reason why we do not need those kind stats for per cpu > >> page_pool? > >> > > > > IIRC discussing with Jakub, we decided to not support them since the pool is not > > associated to any net_device in this case. > > It seems what jakub suggested is to 'extend netlink to dump unbound page pools'? I do not have a strong opinion about it (since we do not have any use-case for it at the moment). In the case we want to support stats for per-cpu page_pools, I think we should not create a per-cpu recycle_stats pointer and add a page_pool_recycle_stats field in page_pool struct since otherwise we will endup with ncpu^2 copies, right? Do we want to support it now? @Jakub, Jesper: what do you guys think? Regards, Lorenzo > > > > > Regards, > > Lorenzo > > >
Attachment:
signature.asc
Description: PGP signature
