Re: Add missing line break in test_verifier

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 01/26/2024 05:59 AM, Andrii Nakryiko wrote:
On Wed, Jan 24, 2024 at 7:13 PM Tiezhu Yang <yangtiezhu@xxxxxxxxxxx> wrote:

Hi Andrii,

There was a line break at the end of printf() in the original patch [1],
but it is missing with small change in the git tree. Would you be able
to squash below trivial change into the current commit [2]?

diff --git a/tools/testing/selftests/bpf/test_verifier.c
b/tools/testing/selftests/bpf/test_verifier.c
index e1a1dfe8d7fa..df04bda1c927 100644
--- a/tools/testing/selftests/bpf/test_verifier.c
+++ b/tools/testing/selftests/bpf/test_verifier.c
@@ -1527,7 +1527,7 @@ static void do_test_single(struct bpf_test *test,
bool unpriv,
         int i, err;

         if ((test->flags & F_NEEDS_JIT_ENABLED) && jit_disabled) {
-               printf("SKIP (requires BPF JIT)");
+               printf("SKIP (requires BPF JIT)\n");

Yeah, my bad, missed adding \n when fixing up message. I don't think
we can fix this up anymore, would you be able to send this as a proper
patch and we can apply this?

OK, will do it as soon as possible.

Thanks,
Tiezhu





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux