Add missing line break in test_verifier

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrii,

There was a line break at the end of printf() in the original patch [1],
but it is missing with small change in the git tree. Would you be able
to squash below trivial change into the current commit [2]?

diff --git a/tools/testing/selftests/bpf/test_verifier.c b/tools/testing/selftests/bpf/test_verifier.c
index e1a1dfe8d7fa..df04bda1c927 100644
--- a/tools/testing/selftests/bpf/test_verifier.c
+++ b/tools/testing/selftests/bpf/test_verifier.c
@@ -1527,7 +1527,7 @@ static void do_test_single(struct bpf_test *test, bool unpriv,
        int i, err;

        if ((test->flags & F_NEEDS_JIT_ENABLED) && jit_disabled) {
-               printf("SKIP (requires BPF JIT)");
+               printf("SKIP (requires BPF JIT)\n");
                skips++;
                sched_yield();
                return;

Otherwise, there are no break lines in the test log, like this:

#106/p inline simple bpf_loop call SKIP (requires BPF JIT)#107/p don't inline bpf_loop call, flags non-zero SKIP (requires BPF JIT)#108/p don't inline bpf_loop call, callback non-constant SKIP (requires BPF JIT)#109/p bpf_loop_inline and a dead func SKIP (requires BPF JIT)#110/p bpf_loop_inline stack locations for loop vars SKIP (requires BPF JIT)#111/p inline bpf_loop call in a big program SKIP (requires BPF JIT)#112/p BPF_ST_MEM stack imm non-zero OK

[1] https://lore.kernel.org/bpf/20240123090351.2207-3-yangtiezhu@xxxxxxxxxxx/ [2] https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=0b50478fd877

Thanks,
Tiezhu





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux