On Wed, Jan 3, 2024 at 3:18 PM Eduard Zingerman <eddyz87@xxxxxxxxx> wrote: > > On Wed, 2024-01-03 at 15:12 -0800, Alexei Starovoitov wrote: > [...] > > At the same time I agree that a public function looking different from > > internal is a good thing to have. > > We have LIBBPF_API that is used in the headers. > > Maybe we should start using something similar in .c files > > than there will be no confusion. > > > > Not a strong opinion. > > > > Eduard, > > what's your take? > > I kind-off like private vs. public method encoded as '_' vs. '__'. > But this seem to be a minor detail, personally I grep header file > each time to see if LIBBPF_API is used for certain function and > that is not a big deal. I'll drop patch #1 in v3. This whole naming discussion is just a distraction in this patch set. Long term I think single underscores for internal functions is the right approach, and makes working with the code simpler. But we can save that discussion to another day.
