For a while now all new internal libbpf functions stopped using
<obj>__<method>() naming, which was historically used both for public
APIs and all the helper functions that can be thought of as "methods" of
libbpf "objects" (bpf_object, bpf_map, bpf_program, etc). This
convention turned out to be confusing because of "could be public API"
concerns, requiring double-checking whether a given function needs
special treatment or not (special error return handling, for example).
We've been doing conversion of pre-existing code naming lazily as we
touched relevant functions, but there are still a bunch of functions
remaining that use old double-underscore naming.
To remove all the confusion and inconsistent naming, complete the rename
to keep double-underscore naming only for public APIs.
There are some notable exceptions, though. Libbpf has a bunch of
APIs that are internal to libbpf, but still are used as API boundaries.
For example, bpf_gen__xxx() is designed to be decoupled from libbpf.c's
logic. Similarly, we have hashmap and strset datastructures with their
own internal APIs (some of which are actually used by bpftool as well,
so they are kind-of-internal). For those internal APIs we still keep
API-like naming with double underscores.
No functional changes.
Signed-off-by: Andrii Nakryiko <andrii@xxxxxxxxxx>
---
tools/lib/bpf/libbpf.c | 504 +++++++++++++++++++----------------------
1 file changed, 238 insertions(+), 266 deletions(-)
diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
index ebcfb2147fbd..8e7a50c1ce89 100644
--- a/tools/lib/bpf/libbpf.c
+++ b/tools/lib/bpf/libbpf.c
@@ -68,7 +68,7 @@
#define __printf(a, b) __attribute__((format(printf, a, b)))
-static struct bpf_map *bpf_object__add_map(struct bpf_object *obj);
+static struct bpf_map *bpf_object_add_map(struct bpf_object *obj);
static bool prog_is_subprog(const struct bpf_object *obj, const struct bpf_program *prog);
static const char * const attach_type_name[] = {
@@ -479,7 +479,7 @@ struct bpf_struct_ops {
* struct tcp_congestion_ops data;
* }
* kern_vdata-size == sizeof(struct bpf_struct_ops_tcp_congestion_ops)
- * bpf_map__init_kern_struct_ops() will populate the "kern_vdata"
+ * bpf_map_init_kern_struct_ops() will populate the "kern_vdata"
* from "data".
*/
void *kern_vdata;
@@ -717,7 +717,7 @@ void bpf_program__unload(struct bpf_program *prog)
zfree(&prog->line_info);
}
-static void bpf_program__exit(struct bpf_program *prog)
+static void bpf_program_exit(struct bpf_program *prog)
{
if (!prog)
return;
@@ -753,10 +753,9 @@ static bool insn_is_pseudo_func(struct bpf_insn *insn)
return is_ldimm64_insn(insn) && insn->src_reg == BPF_PSEUDO_FUNC;
}
-static int
-bpf_object__init_prog(struct bpf_object *obj, struct bpf_program *prog,
- const char *name, size_t sec_idx, const char *sec_name,
- size_t sec_off, void *insn_data, size_t insn_data_sz)
+static int bpf_object_init_prog(struct bpf_object *obj, struct bpf_program *prog,
+ const char *name, size_t sec_idx, const char *sec_name,
+ size_t sec_off, void *insn_data, size_t insn_data_sz)
{
if (insn_data_sz == 0 || insn_data_sz % BPF_INSN_SZ || sec_off % BPF_INSN_SZ) {
pr_warn("sec '%s': corrupted program '%s', offset %zu, size %zu\n",
@@ -810,13 +809,12 @@ bpf_object__init_prog(struct bpf_object *obj, struct bpf_program *prog,
return 0;
errout:
pr_warn("sec '%s': failed to allocate memory for prog '%s'\n", sec_name, name);
- bpf_program__exit(prog);
+ bpf_program_exit(prog);
return -ENOMEM;
}
-static int
-bpf_object__add_programs(struct bpf_object *obj, Elf_Data *sec_data,
- const char *sec_name, int sec_idx)
+static int bpf_object_add_programs(struct bpf_object *obj, Elf_Data *sec_data,
+ const char *sec_name, int sec_idx)
{
Elf_Data *symbols = obj->efile.symbols;
struct bpf_program *prog, *progs;
@@ -877,8 +875,8 @@ bpf_object__add_programs(struct bpf_object *obj, Elf_Data *sec_data,
prog = &progs[nr_progs];
- err = bpf_object__init_prog(obj, prog, name, sec_idx, sec_name,
- sec_off, data + sec_off, prog_sz);
+ err = bpf_object_init_prog(obj, prog, name, sec_idx, sec_name,
+ sec_off, data + sec_off, prog_sz);
if (err)
return err;
@@ -993,15 +991,15 @@ find_struct_ops_kern_types(const struct btf *btf, const char *tname,
return 0;
}
-static bool bpf_map__is_struct_ops(const struct bpf_map *map)
+static bool bpf_map_is_struct_ops(const struct bpf_map *map)
{
return map->def.type == BPF_MAP_TYPE_STRUCT_OPS;
}
/* Init the map's fields that depend on kern_btf */
-static int bpf_map__init_kern_struct_ops(struct bpf_map *map,
- const struct btf *btf,
- const struct btf *kern_btf)
+static int bpf_map_init_kern_struct_ops(struct bpf_map *map,
+ const struct btf *btf,
+ const struct btf *kern_btf)
{
const struct btf_member *member, *kern_member, *kern_data_member;
const struct btf_type *type, *kern_type, *kern_vtype;
@@ -1090,7 +1088,7 @@ static int bpf_map__init_kern_struct_ops(struct bpf_map *map,
&kern_mtype_id);
/* mtype->type must be a func_proto which was
- * guaranteed in bpf_object__collect_st_ops_relos(),
+ * guaranteed in bpf_object_collect_st_ops_relos(),
* so only check kern_mtype for func_proto here.
*/
if (!btf_is_func_proto(kern_mtype)) {
@@ -1129,7 +1127,7 @@ static int bpf_map__init_kern_struct_ops(struct bpf_map *map,
return 0;
}
-static int bpf_object__init_kern_struct_ops_maps(struct bpf_object *obj)
+static int bpf_object_init_kern_struct_ops_maps(struct bpf_object *obj)
{
struct bpf_map *map;
size_t i;
@@ -1138,11 +1136,10 @@ static int bpf_object__init_kern_struct_ops_maps(struct bpf_object *obj)
for (i = 0; i < obj->nr_maps; i++) {
map = &obj->maps[i];
- if (!bpf_map__is_struct_ops(map))
+ if (!bpf_map_is_struct_ops(map))
continue;
- err = bpf_map__init_kern_struct_ops(map, obj->btf,
- obj->btf_vmlinux);
+ err = bpf_map_init_kern_struct_ops(map, obj->btf, obj->btf_vmlinux);
if (err)
return err;
}
@@ -1198,7 +1195,7 @@ static int init_struct_ops_maps(struct bpf_object *obj, const char *sec_name,
return -EINVAL;
}
- map = bpf_object__add_map(obj);
+ map = bpf_object_add_map(obj);
if (IS_ERR(map))
return PTR_ERR(map);
@@ -1258,10 +1255,10 @@ static int bpf_object_init_struct_ops(struct bpf_object *obj)
return err;
}
-static struct bpf_object *bpf_object__new(const char *path,
- const void *obj_buf,
- size_t obj_buf_sz,
- const char *obj_name)
+static struct bpf_object *bpf_object_new(const char *path,
+ const void *obj_buf,
+ size_t obj_buf_sz,
+ const char *obj_name)
{
struct bpf_object *obj;
char *end;
@@ -1286,7 +1283,7 @@ static struct bpf_object *bpf_object__new(const char *path,
obj->efile.fd = -1;
/*
* Caller of this function should also call
- * bpf_object__elf_finish() after data collection to return
+ * bpf_object_elf_finish() after data collection to return
* obj_buf to user. If not, we should duplicate the buffer to
* avoid user freeing them before elf finish.
*/
@@ -1303,7 +1300,7 @@ static struct bpf_object *bpf_object__new(const char *path,
return obj;
}
-static void bpf_object__elf_finish(struct bpf_object *obj)
+static void bpf_object_elf_finish(struct bpf_object *obj)
{
if (!obj->efile.elf)
return;
@@ -1321,7 +1318,7 @@ static void bpf_object__elf_finish(struct bpf_object *obj)
obj->efile.obj_buf_sz = 0;
}
-static int bpf_object__elf_init(struct bpf_object *obj)
+static int bpf_object_elf_init(struct bpf_object *obj)
{
Elf64_Ehdr *ehdr;
int err = 0;
@@ -1400,11 +1397,11 @@ static int bpf_object__elf_init(struct bpf_object *obj)
return 0;
errout:
- bpf_object__elf_finish(obj);
+ bpf_object_elf_finish(obj);
return err;
}
-static int bpf_object__check_endianness(struct bpf_object *obj)
+static int bpf_object_check_endianness(struct bpf_object *obj)
{
#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
if (obj->efile.ehdr->e_ident[EI_DATA] == ELFDATA2LSB)
@@ -1419,8 +1416,7 @@ static int bpf_object__check_endianness(struct bpf_object *obj)
return -LIBBPF_ERRNO__ENDIAN;
}
-static int
-bpf_object__init_license(struct bpf_object *obj, void *data, size_t size)
+static int bpf_object_init_license(struct bpf_object *obj, void *data, size_t size)
{
if (!data) {
pr_warn("invalid license section in %s\n", obj->path);
@@ -1434,8 +1430,7 @@ bpf_object__init_license(struct bpf_object *obj, void *data, size_t size)
return 0;
}
-static int
-bpf_object__init_kversion(struct bpf_object *obj, void *data, size_t size)
+static int bpf_object_init_kversion(struct bpf_object *obj, void *data, size_t size)
{
__u32 kver;
@@ -1449,7 +1444,7 @@ bpf_object__init_kversion(struct bpf_object *obj, void *data, size_t size)
return 0;
}
-static bool bpf_map_type__is_map_in_map(enum bpf_map_type type)
+static bool bpf_map_type_is_map_in_map(enum bpf_map_type type)
{
if (type == BPF_MAP_TYPE_ARRAY_OF_MAPS ||
type == BPF_MAP_TYPE_HASH_OF_MAPS)
@@ -1503,7 +1498,7 @@ static Elf64_Sym *find_elf_var_sym(const struct bpf_object *obj, const char *nam
return ERR_PTR(-ENOENT);
}
-static struct bpf_map *bpf_object__add_map(struct bpf_object *obj)
+static struct bpf_map *bpf_object_add_map(struct bpf_object *obj)
{
struct bpf_map *map;
int err;
@@ -1645,15 +1640,15 @@ static bool map_is_mmapable(struct bpf_object *obj, struct bpf_map *map)
}
static int
-bpf_object__init_internal_map(struct bpf_object *obj, enum libbpf_map_type type,
- const char *real_name, int sec_idx, void *data, size_t data_sz)
+bpf_object_init_internal_map(struct bpf_object *obj, enum libbpf_map_type type,
+ const char *real_name, int sec_idx, void *data, size_t data_sz)
{
struct bpf_map_def *def;
struct bpf_map *map;
size_t mmap_sz;
int err;
- map = bpf_object__add_map(obj);
+ map = bpf_object_add_map(obj);
if (IS_ERR(map))
return PTR_ERR(map);
@@ -1705,7 +1700,7 @@ bpf_object__init_internal_map(struct bpf_object *obj, enum libbpf_map_type type,
return 0;
}
-static int bpf_object__init_global_data_maps(struct bpf_object *obj)
+static int bpf_object_init_global_data_maps(struct bpf_object *obj)
{
struct elf_sec_desc *sec_desc;
const char *sec_name;
@@ -1724,25 +1719,25 @@ static int bpf_object__init_global_data_maps(struct bpf_object *obj)
switch (sec_desc->sec_type) {
case SEC_DATA:
sec_name = elf_sec_name(obj, elf_sec_by_idx(obj, sec_idx));
- err = bpf_object__init_internal_map(obj, LIBBPF_MAP_DATA,
- sec_name, sec_idx,
- sec_desc->data->d_buf,
- sec_desc->data->d_size);
+ err = bpf_object_init_internal_map(obj, LIBBPF_MAP_DATA,
+ sec_name, sec_idx,
+ sec_desc->data->d_buf,
+ sec_desc->data->d_size);
break;
case SEC_RODATA:
obj->has_rodata = true;
sec_name = elf_sec_name(obj, elf_sec_by_idx(obj, sec_idx));
- err = bpf_object__init_internal_map(obj, LIBBPF_MAP_RODATA,
- sec_name, sec_idx,
- sec_desc->data->d_buf,
- sec_desc->data->d_size);
+ err = bpf_object_init_internal_map(obj, LIBBPF_MAP_RODATA,
+ sec_name, sec_idx,
+ sec_desc->data->d_buf,
+ sec_desc->data->d_size);
break;
case SEC_BSS:
sec_name = elf_sec_name(obj, elf_sec_by_idx(obj, sec_idx));
- err = bpf_object__init_internal_map(obj, LIBBPF_MAP_BSS,
- sec_name, sec_idx,
- NULL,
- sec_desc->data->d_size);
+ err = bpf_object_init_internal_map(obj, LIBBPF_MAP_BSS,
+ sec_name, sec_idx,
+ NULL,
+ sec_desc->data->d_size);
break;
default:
/* skip */
@@ -1917,8 +1912,7 @@ static int set_kcfg_value_num(struct extern_desc *ext, void *ext_val,
return 0;
}
-static int bpf_object__process_kconfig_line(struct bpf_object *obj,
- char *buf, void *data)
+static int bpf_object_process_kconfig_line(struct bpf_object *obj, char *buf, void *data)
{
struct extern_desc *ext;
char *sep, *value;
@@ -1981,7 +1975,7 @@ static int bpf_object__process_kconfig_line(struct bpf_object *obj,
return 0;
}
-static int bpf_object__read_kconfig_file(struct bpf_object *obj, void *data)
+static int bpf_object_read_kconfig_file(struct bpf_object *obj, void *data)
{
char buf[PATH_MAX];
struct utsname uts;
@@ -2006,7 +2000,7 @@ static int bpf_object__read_kconfig_file(struct bpf_object *obj, void *data)
}
while (gzgets(file, buf, sizeof(buf))) {
- err = bpf_object__process_kconfig_line(obj, buf, data);
+ err = bpf_object_process_kconfig_line(obj, buf, data);
if (err) {
pr_warn("error parsing system Kconfig line '%s': %d\n",
buf, err);
@@ -2019,8 +2013,7 @@ static int bpf_object__read_kconfig_file(struct bpf_object *obj, void *data)
return err;
}
-static int bpf_object__read_kconfig_mem(struct bpf_object *obj,
- const char *config, void *data)
+static int bpf_object_read_kconfig_mem(struct bpf_object *obj, const char *config, void *data)
{
char buf[PATH_MAX];
int err = 0;
@@ -2034,7 +2027,7 @@ static int bpf_object__read_kconfig_mem(struct bpf_object *obj,
}
while (fgets(buf, sizeof(buf), file)) {
- err = bpf_object__process_kconfig_line(obj, buf, data);
+ err = bpf_object_process_kconfig_line(obj, buf, data);
if (err) {
pr_warn("error parsing in-memory Kconfig line '%s': %d\n",
buf, err);
@@ -2046,7 +2039,7 @@ static int bpf_object__read_kconfig_mem(struct bpf_object *obj,
return err;
}
-static int bpf_object__init_kconfig_map(struct bpf_object *obj)
+static int bpf_object_init_kconfig_map(struct bpf_object *obj)
{
struct extern_desc *last_ext = NULL, *ext;
size_t map_sz;
@@ -2062,9 +2055,9 @@ static int bpf_object__init_kconfig_map(struct bpf_object *obj)
return 0;
map_sz = last_ext->kcfg.data_off + last_ext->kcfg.sz;
- err = bpf_object__init_internal_map(obj, LIBBPF_MAP_KCONFIG,
- ".kconfig", obj->efile.symbols_shndx,
- NULL, map_sz);
+ err = bpf_object_init_internal_map(obj, LIBBPF_MAP_KCONFIG,
+ ".kconfig", obj->efile.symbols_shndx,
+ NULL, map_sz);
if (err)
return err;
@@ -2324,7 +2317,7 @@ int parse_btf_map_def(const char *map_name, struct btf *btf,
map_def->parts |= MAP_DEF_VALUE_SIZE | MAP_DEF_VALUE_TYPE;
}
else if (strcmp(name, "values") == 0) {
- bool is_map_in_map = bpf_map_type__is_map_in_map(map_def->map_type);
+ bool is_map_in_map = bpf_map_type_is_map_in_map(map_def->map_type);
bool is_prog_array = map_def->map_type == BPF_MAP_TYPE_PROG_ARRAY;
const char *desc = is_map_in_map ? "map-in-map inner" : "prog-array value";
char inner_map_name[128];
@@ -2524,11 +2517,11 @@ static const char *btf_var_linkage_str(__u32 linkage)
}
}
-static int bpf_object__init_user_btf_map(struct bpf_object *obj,
- const struct btf_type *sec,
- int var_idx, int sec_idx,
- const Elf_Data *data, bool strict,
- const char *pin_root_path)
+static int bpf_object_init_user_btf_map(struct bpf_object *obj,
+ const struct btf_type *sec,
+ int var_idx, int sec_idx,
+ const Elf_Data *data, bool strict,
+ const char *pin_root_path)
{
struct btf_map_def map_def = {}, inner_def = {};
const struct btf_type *var, *def;
@@ -2573,7 +2566,7 @@ static int bpf_object__init_user_btf_map(struct bpf_object *obj,
return -EINVAL;
}
- map = bpf_object__add_map(obj);
+ map = bpf_object_add_map(obj);
if (IS_ERR(map))
return PTR_ERR(map);
map->name = strdup(map_name);
@@ -2624,8 +2617,8 @@ static int bpf_object__init_user_btf_map(struct bpf_object *obj,
return 0;
}
-static int bpf_object__init_user_btf_maps(struct bpf_object *obj, bool strict,
- const char *pin_root_path)
+static int bpf_object_init_user_btf_maps(struct bpf_object *obj, bool strict,
+ const char *pin_root_path)
{
const struct btf_type *sec = NULL;
int nr_types, i, vlen, err;
@@ -2665,10 +2658,10 @@ static int bpf_object__init_user_btf_maps(struct bpf_object *obj, bool strict,
vlen = btf_vlen(sec);
for (i = 0; i < vlen; i++) {
- err = bpf_object__init_user_btf_map(obj, sec, i,
- obj->efile.btf_maps_shndx,
- data, strict,
- pin_root_path);
+ err = bpf_object_init_user_btf_map(obj, sec, i,
+ obj->efile.btf_maps_shndx,
+ data, strict,
+ pin_root_path);
if (err)
return err;
}
@@ -2676,8 +2669,7 @@ static int bpf_object__init_user_btf_maps(struct bpf_object *obj, bool strict,
return 0;
}
-static int bpf_object__init_maps(struct bpf_object *obj,
- const struct bpf_object_open_opts *opts)
+static int bpf_object_init_maps(struct bpf_object *obj, const struct bpf_object_open_opts *opts)
{
const char *pin_root_path;
bool strict;
@@ -2686,9 +2678,9 @@ static int bpf_object__init_maps(struct bpf_object *obj,
strict = !OPTS_GET(opts, relaxed_maps, false);
pin_root_path = OPTS_GET(opts, pin_root_path, NULL);
- err = bpf_object__init_user_btf_maps(obj, strict, pin_root_path);
- err = err ?: bpf_object__init_global_data_maps(obj);
- err = err ?: bpf_object__init_kconfig_map(obj);
+ err = bpf_object_init_user_btf_maps(obj, strict, pin_root_path);
+ err = err ?: bpf_object_init_global_data_maps(obj);
+ err = err ?: bpf_object_init_kconfig_map(obj);
err = err ?: bpf_object_init_struct_ops(obj);
return err;
@@ -2719,7 +2711,7 @@ static bool btf_needs_sanitization(struct bpf_object *obj)
!has_decl_tag || !has_type_tag || !has_enum64;
}
-static int bpf_object__sanitize_btf(struct bpf_object *obj, struct btf *btf)
+static int bpf_object_sanitize_btf(struct bpf_object *obj, struct btf *btf)
{
bool has_func_global = kernel_supports(obj, FEAT_BTF_GLOBAL_FUNC);
bool has_datasec = kernel_supports(obj, FEAT_BTF_DATASEC);
@@ -2832,9 +2824,7 @@ static bool kernel_needs_btf(const struct bpf_object *obj)
return obj->efile.st_ops_shndx >= 0 || obj->efile.st_ops_link_shndx >= 0;
}
-static int bpf_object__init_btf(struct bpf_object *obj,
- Elf_Data *btf_data,
- Elf_Data *btf_ext_data)
+static int bpf_object_init_btf(struct bpf_object *obj, Elf_Data *btf_data, Elf_Data *btf_ext_data)
{
int err = -ENOENT;
@@ -3056,7 +3046,7 @@ static bool prog_needs_vmlinux_btf(struct bpf_program *prog)
static bool map_needs_vmlinux_btf(struct bpf_map *map)
{
- return bpf_map__is_struct_ops(map);
+ return bpf_map_is_struct_ops(map);
}
static bool obj_needs_vmlinux_btf(const struct bpf_object *obj)
@@ -3095,7 +3085,7 @@ static bool obj_needs_vmlinux_btf(const struct bpf_object *obj)
return false;
}
-static int bpf_object__load_vmlinux_btf(struct bpf_object *obj, bool force)
+static int bpf_object_load_vmlinux_btf(struct bpf_object *obj, bool force)
{
int err;
@@ -3116,7 +3106,7 @@ static int bpf_object__load_vmlinux_btf(struct bpf_object *obj, bool force)
return 0;
}
-static int bpf_object__sanitize_and_load_btf(struct bpf_object *obj)
+static int bpf_object_sanitize_and_load_btf(struct bpf_object *obj)
{
struct btf *kern_btf = obj->btf;
bool btf_mandatory, sanitize;
@@ -3260,7 +3250,7 @@ static int bpf_object__sanitize_and_load_btf(struct bpf_object *obj)
/* enforce 8-byte pointers for BPF-targeted BTFs */
btf__set_pointer_size(obj->btf, 8);
- err = bpf_object__sanitize_btf(obj, kern_btf);
+ err = bpf_object_sanitize_btf(obj, kern_btf);
if (err)
return err;
}
@@ -3486,7 +3476,7 @@ static int cmp_progs(const void *_a, const void *_b)
return a->sec_insn_off < b->sec_insn_off ? -1 : 1;
}
-static int bpf_object__elf_collect(struct bpf_object *obj)
+static int bpf_object_elf_collect(struct bpf_object *obj)
{
struct elf_sec_desc *sec_desc;
Elf *elf = obj->efile.elf;
@@ -3571,11 +3561,11 @@ static int bpf_object__elf_collect(struct bpf_object *obj)
(int)sh->sh_type);
if (strcmp(name, "license") == 0) {
- err = bpf_object__init_license(obj, data->d_buf, data->d_size);
+ err = bpf_object_init_license(obj, data->d_buf, data->d_size);
if (err)
return err;
} else if (strcmp(name, "version") == 0) {
- err = bpf_object__init_kversion(obj, data->d_buf, data->d_size);
+ err = bpf_object_init_kversion(obj, data->d_buf, data->d_size);
if (err)
return err;
} else if (strcmp(name, "maps") == 0) {
@@ -3597,7 +3587,7 @@ static int bpf_object__elf_collect(struct bpf_object *obj)
if (sh->sh_flags & SHF_EXECINSTR) {
if (strcmp(name, ".text") == 0)
obj->efile.text_shndx = idx;
- err = bpf_object__add_programs(obj, data, name, idx);
+ err = bpf_object_add_programs(obj, data, name, idx);
if (err)
return err;
} else if (strcmp(name, DATA_SEC) == 0 ||
@@ -3663,7 +3653,7 @@ static int bpf_object__elf_collect(struct bpf_object *obj)
if (obj->nr_programs)
qsort(obj->programs, obj->nr_programs, sizeof(*obj->programs), cmp_progs);
- return bpf_object__init_btf(obj, btf_data, btf_ext_data);
+ return bpf_object_init_btf(obj, btf_data, btf_ext_data);
}
static bool sym_is_extern(const Elf64_Sym *sym)
@@ -3872,7 +3862,7 @@ static int add_dummy_ksym_var(struct btf *btf)
return dummy_var_btf_id;
}
-static int bpf_object__collect_externs(struct bpf_object *obj)
+static int bpf_object_collect_externs(struct bpf_object *obj)
{
struct btf_type *sec, *kcfg_sec = NULL, *ksym_sec = NULL;
const struct btf_type *t;
@@ -4111,8 +4101,7 @@ bpf_object__find_program_by_name(const struct bpf_object *obj,
return errno = ENOENT, NULL;
}
-static bool bpf_object__shndx_is_data(const struct bpf_object *obj,
- int shndx)
+static bool bpf_object_shndx_is_data(const struct bpf_object *obj, int shndx)
{
switch (obj->efile.secs[shndx].sec_type) {
case SEC_BSS:
@@ -4124,14 +4113,13 @@ static bool bpf_object__shndx_is_data(const struct bpf_object *obj,
}
}
-static bool bpf_object__shndx_is_maps(const struct bpf_object *obj,
+static bool bpf_object_shndx_is_maps(const struct bpf_object *obj,
int shndx)
{
return shndx == obj->efile.btf_maps_shndx;
}
-static enum libbpf_map_type
-bpf_object__section_to_libbpf_map_type(const struct bpf_object *obj, int shndx)
+static enum libbpf_map_type map_section_to_libbpf_map_type(const struct bpf_object *obj, int shndx)
{
if (shndx == obj->efile.symbols_shndx)
return LIBBPF_MAP_KCONFIG;
@@ -4148,10 +4136,10 @@ bpf_object__section_to_libbpf_map_type(const struct bpf_object *obj, int shndx)
}
}
-static int bpf_program__record_reloc(struct bpf_program *prog,
- struct reloc_desc *reloc_desc,
- __u32 insn_idx, const char *sym_name,
- const Elf64_Sym *sym, const Elf64_Rel *rel)
+static int bpf_program_record_reloc(struct bpf_program *prog,
+ struct reloc_desc *reloc_desc,
+ __u32 insn_idx, const char *sym_name,
+ const Elf64_Sym *sym, const Elf64_Rel *rel)
{
struct bpf_insn *insn = &prog->insns[insn_idx];
size_t map_idx, nr_maps = prog->obj->nr_maps;
@@ -4240,12 +4228,12 @@ static int bpf_program__record_reloc(struct bpf_program *prog,
return 0;
}
- type = bpf_object__section_to_libbpf_map_type(obj, shdr_idx);
+ type = map_section_to_libbpf_map_type(obj, shdr_idx);
sym_sec_name = elf_sec_name(obj, elf_sec_by_idx(obj, shdr_idx));
/* generic map reference relocation */
if (type == LIBBPF_MAP_UNSPEC) {
- if (!bpf_object__shndx_is_maps(obj, shdr_idx)) {
+ if (!bpf_object_shndx_is_maps(obj, shdr_idx)) {
pr_warn("prog '%s': bad map relo against '%s' in section '%s'\n",
prog->name, sym_name, sym_sec_name);
return -LIBBPF_ERRNO__RELOC;
@@ -4274,7 +4262,7 @@ static int bpf_program__record_reloc(struct bpf_program *prog,
}
/* global data map relocation */
- if (!bpf_object__shndx_is_data(obj, shdr_idx)) {
+ if (!bpf_object_shndx_is_data(obj, shdr_idx)) {
pr_warn("prog '%s': bad data relo against section '%s'\n",
prog->name, sym_sec_name);
return -LIBBPF_ERRNO__RELOC;
@@ -4335,8 +4323,7 @@ static struct bpf_program *find_prog_by_sec_insn(const struct bpf_object *obj,
return NULL;
}
-static int
-bpf_object__collect_prog_relos(struct bpf_object *obj, Elf64_Shdr *shdr, Elf_Data *data)
+static int bpf_object_collect_prog_relos(struct bpf_object *obj, Elf64_Shdr *shdr, Elf_Data *data)
{
const char *relo_sec_name, *sec_name;
size_t sec_idx = shdr->sh_info, sym_idx;
@@ -4425,8 +4412,8 @@ bpf_object__collect_prog_relos(struct bpf_object *obj, Elf64_Shdr *shdr, Elf_Dat
/* adjust insn_idx to local BPF program frame of reference */
insn_idx -= prog->sec_insn_off;
- err = bpf_program__record_reloc(prog, &relos[prog->nr_reloc],
- insn_idx, sym_name, sym, rel);
+ err = bpf_program_record_reloc(prog, &relos[prog->nr_reloc],
+ insn_idx, sym_name, sym, rel);
if (err)
return err;
@@ -4446,7 +4433,7 @@ static int map_fill_btf_type_info(struct bpf_object *obj, struct bpf_map *map)
* For struct_ops map, it does not need btf_key_type_id and
* btf_value_type_id.
*/
- if (map->sec_idx == obj->efile.btf_maps_shndx || bpf_map__is_struct_ops(map))
+ if (map->sec_idx == obj->efile.btf_maps_shndx || bpf_map_is_struct_ops(map))
return 0;
/*
@@ -4584,7 +4571,7 @@ __u32 bpf_map__max_entries(const struct bpf_map *map)
struct bpf_map *bpf_map__inner_map(struct bpf_map *map)
{
- if (!bpf_map_type__is_map_in_map(map->def.type))
+ if (!bpf_map_type_is_map_in_map(map->def.type))
return errno = EINVAL, NULL;
return map->inner_map;
@@ -4604,8 +4591,7 @@ int bpf_map__set_max_entries(struct bpf_map *map, __u32 max_entries)
return 0;
}
-static int
-bpf_object__probe_loading(struct bpf_object *obj)
+static int bpf_object_probe_loading(struct bpf_object *obj)
{
char *cp, errmsg[STRERR_BUFSIZE];
struct bpf_insn insns[] = {
@@ -5122,8 +5108,7 @@ static bool map_is_reuse_compat(const struct bpf_map *map, int map_fd)
map_info.map_extra == map->map_extra);
}
-static int
-bpf_object__reuse_map(struct bpf_map *map)
+static int bpf_object_reuse_map(struct bpf_map *map)
{
char *cp, errmsg[STRERR_BUFSIZE];
int err, pin_fd;
@@ -5161,8 +5146,7 @@ bpf_object__reuse_map(struct bpf_map *map)
return 0;
}
-static int
-bpf_object__populate_internal_map(struct bpf_object *obj, struct bpf_map *map)
+static int bpf_object_populate_internal_map(struct bpf_object *obj, struct bpf_map *map)
{
enum libbpf_map_type map_type = map->libbpf_type;
char *cp, errmsg[STRERR_BUFSIZE];
@@ -5198,9 +5182,9 @@ bpf_object__populate_internal_map(struct bpf_object *obj, struct bpf_map *map)
return 0;
}
-static void bpf_map__destroy(struct bpf_map *map);
+static void bpf_map_destroy(struct bpf_map *map);
-static int bpf_object__create_map(struct bpf_object *obj, struct bpf_map *map, bool is_inner)
+static int bpf_object_create_map(struct bpf_object *obj, struct bpf_map *map, bool is_inner)
{
LIBBPF_OPTS(bpf_map_create_opts, create_attr);
struct bpf_map_def *def = &map->def;
@@ -5214,7 +5198,7 @@ static int bpf_object__create_map(struct bpf_object *obj, struct bpf_map *map, b
create_attr.numa_node = map->numa_node;
create_attr.map_extra = map->map_extra;
- if (bpf_map__is_struct_ops(map))
+ if (bpf_map_is_struct_ops(map))
create_attr.btf_vmlinux_value_type_id = map->btf_vmlinux_value_type_id;
if (obj->btf && btf__fd(obj->btf) >= 0) {
@@ -5223,9 +5207,9 @@ static int bpf_object__create_map(struct bpf_object *obj, struct bpf_map *map, b
create_attr.btf_value_type_id = map->btf_value_type_id;
}
- if (bpf_map_type__is_map_in_map(def->type)) {
+ if (bpf_map_type_is_map_in_map(def->type)) {
if (map->inner_map) {
- err = bpf_object__create_map(obj, map->inner_map, true);
+ err = bpf_object_create_map(obj, map->inner_map, true);
if (err) {
pr_warn("map '%s': failed to create inner map: %d\n",
map->name, err);
@@ -5293,10 +5277,10 @@ static int bpf_object__create_map(struct bpf_object *obj, struct bpf_map *map, b
err = map->fd < 0 ? -errno : 0;
- if (bpf_map_type__is_map_in_map(def->type) && map->inner_map) {
+ if (bpf_map_type_is_map_in_map(def->type) && map->inner_map) {
if (obj->gen_loader)
map->inner_map->fd = -1;
- bpf_map__destroy(map->inner_map);
+ bpf_map_destroy(map->inner_map);
zfree(&map->inner_map);
}
@@ -5410,8 +5394,7 @@ static int map_set_def_max_entries(struct bpf_map *map)
return 0;
}
-static int
-bpf_object__create_maps(struct bpf_object *obj)
+static int bpf_object_create_maps(struct bpf_object *obj)
{
struct bpf_map *map;
char *cp, errmsg[STRERR_BUFSIZE];
@@ -5451,7 +5434,7 @@ bpf_object__create_maps(struct bpf_object *obj)
retried = false;
retry:
if (map->pin_path) {
- err = bpf_object__reuse_map(map);
+ err = bpf_object_reuse_map(map);
if (err) {
pr_warn("map '%s': error reusing pinned map\n",
map->name);
@@ -5469,7 +5452,7 @@ bpf_object__create_maps(struct bpf_object *obj)
pr_debug("map '%s': skipping creation (preset fd=%d)\n",
map->name, map->fd);
} else {
- err = bpf_object__create_map(obj, map, false);
+ err = bpf_object_create_map(obj, map, false);
if (err)
goto err_out;
@@ -5477,7 +5460,7 @@ bpf_object__create_maps(struct bpf_object *obj)
map->name, map->fd);
if (bpf_map__is_internal(map)) {
- err = bpf_object__populate_internal_map(obj, map);
+ err = bpf_object_populate_internal_map(obj, map);
if (err < 0) {
zclose(map->fd);
goto err_out;
@@ -5879,8 +5862,7 @@ static int bpf_core_resolve_relo(struct bpf_program *prog,
targ_res);
}
-static int
-bpf_object__relocate_core(struct bpf_object *obj, const char *targ_btf_path)
+static int bpf_object_relocate_core(struct bpf_object *obj, const char *targ_btf_path)
{
const struct btf_ext_info_sec *sec;
struct bpf_core_relo_res targ_res;
@@ -6057,8 +6039,7 @@ static void poison_kfunc_call(struct bpf_program *prog, int relo_idx,
* - global variable references;
* - extern references.
*/
-static int
-bpf_object__relocate_data(struct bpf_object *obj, struct bpf_program *prog)
+static int bpf_object_relocate_data(struct bpf_object *obj, struct bpf_program *prog)
{
int i;
@@ -6340,9 +6321,8 @@ static int append_subprog_relos(struct bpf_program *main_prog, struct bpf_progra
return 0;
}
-static int
-bpf_object__append_subprog_code(struct bpf_object *obj, struct bpf_program *main_prog,
- struct bpf_program *subprog)
+static int bpf_object_append_subprog_code(struct bpf_object *obj, struct bpf_program *main_prog,
+ struct bpf_program *subprog)
{
struct bpf_insn *insns;
size_t new_cnt;
@@ -6372,9 +6352,8 @@ bpf_object__append_subprog_code(struct bpf_object *obj, struct bpf_program *main
return 0;
}
-static int
-bpf_object__reloc_code(struct bpf_object *obj, struct bpf_program *main_prog,
- struct bpf_program *prog)
+static int bpf_object_reloc_code(struct bpf_object *obj, struct bpf_program *main_prog,
+ struct bpf_program *prog)
{
size_t sub_insn_idx, insn_idx;
struct bpf_program *subprog;
@@ -6394,7 +6373,7 @@ bpf_object__reloc_code(struct bpf_object *obj, struct bpf_program *main_prog,
relo = find_prog_insn_relo(prog, insn_idx);
if (relo && relo->type == RELO_EXTERN_CALL)
/* kfunc relocations will be handled later
- * in bpf_object__relocate_data()
+ * in bpf_object_relocate_data()
*/
continue;
if (relo && relo->type != RELO_CALL && relo->type != RELO_SUBPROG_ADDR) {
@@ -6454,10 +6433,10 @@ bpf_object__reloc_code(struct bpf_object *obj, struct bpf_program *main_prog,
* and relocate.
*/
if (subprog->sub_insn_off == 0) {
- err = bpf_object__append_subprog_code(obj, main_prog, subprog);
+ err = bpf_object_append_subprog_code(obj, main_prog, subprog);
if (err)
return err;
- err = bpf_object__reloc_code(obj, main_prog, subprog);
+ err = bpf_object_reloc_code(obj, main_prog, subprog);
if (err)
return err;
}
@@ -6562,8 +6541,7 @@ bpf_object__reloc_code(struct bpf_object *obj, struct bpf_program *main_prog,
*
* At this point we unwind recursion, relocate calls in subC, then in mainB.
*/
-static int
-bpf_object__relocate_calls(struct bpf_object *obj, struct bpf_program *prog)
+static int bpf_object_relocate_calls(struct bpf_object *obj, struct bpf_program *prog)
{
struct bpf_program *subprog;
int i, err;
@@ -6579,15 +6557,14 @@ bpf_object__relocate_calls(struct bpf_object *obj, struct bpf_program *prog)
subprog->sub_insn_off = 0;
}
- err = bpf_object__reloc_code(obj, prog, prog);
+ err = bpf_object_reloc_code(obj, prog, prog);
if (err)
return err;
return 0;
}
-static void
-bpf_object__free_relocs(struct bpf_object *obj)
+static void bpf_object_free_relocs(struct bpf_object *obj)
{
struct bpf_program *prog;
int i;
@@ -6615,7 +6592,7 @@ static int cmp_relocs(const void *_a, const void *_b)
return 0;
}
-static void bpf_object__sort_relos(struct bpf_object *obj)
+static void bpf_object_sort_relos(struct bpf_object *obj)
{
int i;
@@ -6630,25 +6607,25 @@ static void bpf_object__sort_relos(struct bpf_object *obj)
}
static int
-bpf_object__relocate(struct bpf_object *obj, const char *targ_btf_path)
+bpf_object_relocate(struct bpf_object *obj, const char *targ_btf_path)
{
struct bpf_program *prog;
size_t i, j;
int err;
if (obj->btf_ext) {
- err = bpf_object__relocate_core(obj, targ_btf_path);
+ err = bpf_object_relocate_core(obj, targ_btf_path);
if (err) {
pr_warn("failed to perform CO-RE relocations: %d\n",
err);
return err;
}
- bpf_object__sort_relos(obj);
+ bpf_object_sort_relos(obj);
}
/* Before relocating calls pre-process relocations and mark
* few ld_imm64 instructions that points to subprogs.
- * Otherwise bpf_object__reloc_code() later would have to consider
+ * Otherwise bpf_object_reloc_code() later would have to consider
* all ld_imm64 insns as relocation candidates. That would
* reduce relocation speed, since amount of find_prog_insn_relo()
* would increase and most of them will fail to find a relo.
@@ -6682,7 +6659,7 @@ bpf_object__relocate(struct bpf_object *obj, const char *targ_btf_path)
if (!prog->autoload)
continue;
- err = bpf_object__relocate_calls(obj, prog);
+ err = bpf_object_relocate_calls(obj, prog);
if (err) {
pr_warn("prog '%s': failed to relocate calls: %d\n",
prog->name, err);
@@ -6699,10 +6676,10 @@ bpf_object__relocate(struct bpf_object *obj, const char *targ_btf_path)
* have to append exception callback now.
*/
if (subprog->sub_insn_off == 0) {
- err = bpf_object__append_subprog_code(obj, prog, subprog);
+ err = bpf_object_append_subprog_code(obj, prog, subprog);
if (err)
return err;
- err = bpf_object__reloc_code(obj, prog, subprog);
+ err = bpf_object_reloc_code(obj, prog, subprog);
if (err)
return err;
}
@@ -6715,7 +6692,7 @@ bpf_object__relocate(struct bpf_object *obj, const char *targ_btf_path)
continue;
if (!prog->autoload)
continue;
- err = bpf_object__relocate_data(obj, prog);
+ err = bpf_object_relocate_data(obj, prog);
if (err) {
pr_warn("prog '%s': failed to relocate data references: %d\n",
prog->name, err);
@@ -6726,11 +6703,11 @@ bpf_object__relocate(struct bpf_object *obj, const char *targ_btf_path)
return 0;
}
-static int bpf_object__collect_st_ops_relos(struct bpf_object *obj,
- Elf64_Shdr *shdr, Elf_Data *data);
+static int bpf_object_collect_st_ops_relos(struct bpf_object *obj,
+ Elf64_Shdr *shdr, Elf_Data *data);
-static int bpf_object__collect_map_relos(struct bpf_object *obj,
- Elf64_Shdr *shdr, Elf_Data *data)
+static int bpf_object_collect_map_relos(struct bpf_object *obj,
+ Elf64_Shdr *shdr, Elf_Data *data)
{
const int bpf_ptr_sz = 8, host_ptr_sz = sizeof(void *);
int i, j, nrels, new_sz;
@@ -6788,7 +6765,7 @@ static int bpf_object__collect_map_relos(struct bpf_object *obj,
return -EINVAL;
}
- is_map_in_map = bpf_map_type__is_map_in_map(map->def.type);
+ is_map_in_map = bpf_map_type_is_map_in_map(map->def.type);
is_prog_array = map->def.type == BPF_MAP_TYPE_PROG_ARRAY;
type = is_map_in_map ? "map" : "prog";
if (is_map_in_map) {
@@ -6866,7 +6843,7 @@ static int bpf_object__collect_map_relos(struct bpf_object *obj,
return 0;
}
-static int bpf_object__collect_relos(struct bpf_object *obj)
+static int bpf_object_collect_relos(struct bpf_object *obj)
{
int i, err;
@@ -6889,16 +6866,16 @@ static int bpf_object__collect_relos(struct bpf_object *obj)
}
if (idx == obj->efile.st_ops_shndx || idx == obj->efile.st_ops_link_shndx)
- err = bpf_object__collect_st_ops_relos(obj, shdr, data);
+ err = bpf_object_collect_st_ops_relos(obj, shdr, data);
else if (idx == obj->efile.btf_maps_shndx)
- err = bpf_object__collect_map_relos(obj, shdr, data);
+ err = bpf_object_collect_map_relos(obj, shdr, data);
else
- err = bpf_object__collect_prog_relos(obj, shdr, data);
+ err = bpf_object_collect_prog_relos(obj, shdr, data);
if (err)
return err;
}
- bpf_object__sort_relos(obj);
+ bpf_object_sort_relos(obj);
return 0;
}
@@ -6915,7 +6892,7 @@ static bool insn_is_helper_call(struct bpf_insn *insn, enum bpf_func_id *func_id
return false;
}
-static int bpf_object__sanitize_prog(struct bpf_object *obj, struct bpf_program *prog)
+static int bpf_object_sanitize_prog(struct bpf_object *obj, struct bpf_program *prog)
{
struct bpf_insn *insn = prog->insns;
enum bpf_func_id func_id;
@@ -7433,7 +7410,7 @@ static int bpf_program_record_relos(struct bpf_program *prog)
}
static int
-bpf_object__load_progs(struct bpf_object *obj, int log_level)
+bpf_object_load_progs(struct bpf_object *obj, int log_level)
{
struct bpf_program *prog;
size_t i;
@@ -7441,7 +7418,7 @@ bpf_object__load_progs(struct bpf_object *obj, int log_level)
for (i = 0; i < obj->nr_programs; i++) {
prog = &obj->programs[i];
- err = bpf_object__sanitize_prog(obj, prog);
+ err = bpf_object_sanitize_prog(obj, prog);
if (err)
return err;
}
@@ -7467,7 +7444,7 @@ bpf_object__load_progs(struct bpf_object *obj, int log_level)
}
}
- bpf_object__free_relocs(obj);
+ bpf_object_free_relocs(obj);
return 0;
}
@@ -7546,7 +7523,7 @@ static struct bpf_object *bpf_object_open(const char *path, const void *obj_buf,
if (log_size && !log_buf)
return ERR_PTR(-EINVAL);
- obj = bpf_object__new(path, obj_buf, obj_buf_sz, obj_name);
+ obj = bpf_object_new(path, obj_buf, obj_buf_sz, obj_name);
if (IS_ERR(obj))
return obj;
@@ -7576,18 +7553,18 @@ static struct bpf_object *bpf_object_open(const char *path, const void *obj_buf,
}
}
- err = bpf_object__elf_init(obj);
- err = err ? : bpf_object__check_endianness(obj);
- err = err ? : bpf_object__elf_collect(obj);
- err = err ? : bpf_object__collect_externs(obj);
+ err = bpf_object_elf_init(obj);
+ err = err ? : bpf_object_check_endianness(obj);
+ err = err ? : bpf_object_elf_collect(obj);
+ err = err ? : bpf_object_collect_externs(obj);
err = err ? : bpf_object_fixup_btf(obj);
- err = err ? : bpf_object__init_maps(obj, opts);
+ err = err ? : bpf_object_init_maps(obj, opts);
err = err ? : bpf_object_init_progs(obj, opts);
- err = err ? : bpf_object__collect_relos(obj);
+ err = err ? : bpf_object_collect_relos(obj);
if (err)
goto out;
- bpf_object__elf_finish(obj);
+ bpf_object_elf_finish(obj);
return obj;
out:
@@ -7640,7 +7617,7 @@ static int bpf_object_unload(struct bpf_object *obj)
return 0;
}
-static int bpf_object__sanitize_maps(struct bpf_object *obj)
+static int bpf_object_sanitize_maps(struct bpf_object *obj)
{
struct bpf_map *m;
@@ -7716,7 +7693,7 @@ static int kallsyms_cb(unsigned long long sym_addr, char sym_type,
return 0;
}
-static int bpf_object__read_kallsyms_file(struct bpf_object *obj)
+static int bpf_object_read_kallsyms_file(struct bpf_object *obj)
{
return libbpf_kallsyms_parse(kallsyms_cb, obj);
}
@@ -7755,8 +7732,7 @@ static int find_ksym_btf_id(struct bpf_object *obj, const char *ksym_name,
return id;
}
-static int bpf_object__resolve_ksym_var_btf_id(struct bpf_object *obj,
- struct extern_desc *ext)
+static int bpf_object_resolve_ksym_var_btf_id(struct bpf_object *obj, struct extern_desc *ext)
{
const struct btf_type *targ_var, *targ_type;
__u32 targ_type_id, local_type_id;
@@ -7808,8 +7784,7 @@ static int bpf_object__resolve_ksym_var_btf_id(struct bpf_object *obj,
return 0;
}
-static int bpf_object__resolve_ksym_func_btf_id(struct bpf_object *obj,
- struct extern_desc *ext)
+static int bpf_object_resolve_ksym_func_btf_id(struct bpf_object *obj, struct extern_desc *ext)
{
int local_func_proto_id, kfunc_proto_id, kfunc_id;
struct module_btf *mod_btf = NULL;
@@ -7868,7 +7843,7 @@ static int bpf_object__resolve_ksym_func_btf_id(struct bpf_object *obj,
ext->is_set = true;
ext->ksym.kernel_btf_id = kfunc_id;
ext->ksym.btf_fd_idx = mod_btf ? mod_btf->fd_array_idx : 0;
- /* Also set kernel_btf_obj_fd to make sure that bpf_object__relocate_data()
+ /* Also set kernel_btf_obj_fd to make sure that bpf_object_relocate_data()
* populates FD into ld_imm64 insn when it's used to point to kfunc.
* {kernel_btf_id, btf_fd_idx} -> fixup bpf_call.
* {kernel_btf_id, kernel_btf_obj_fd} -> fixup ld_imm64.
@@ -7880,7 +7855,7 @@ static int bpf_object__resolve_ksym_func_btf_id(struct bpf_object *obj,
return 0;
}
-static int bpf_object__resolve_ksyms_btf_id(struct bpf_object *obj)
+static int bpf_object_resolve_ksyms_btf_id(struct bpf_object *obj)
{
const struct btf_type *t;
struct extern_desc *ext;
@@ -7899,17 +7874,16 @@ static int bpf_object__resolve_ksyms_btf_id(struct bpf_object *obj)
}
t = btf__type_by_id(obj->btf, ext->btf_id);
if (btf_is_var(t))
- err = bpf_object__resolve_ksym_var_btf_id(obj, ext);
+ err = bpf_object_resolve_ksym_var_btf_id(obj, ext);
else
- err = bpf_object__resolve_ksym_func_btf_id(obj, ext);
+ err = bpf_object_resolve_ksym_func_btf_id(obj, ext);
if (err)
return err;
}
return 0;
}
-static int bpf_object__resolve_externs(struct bpf_object *obj,
- const char *extra_kconfig)
+static int bpf_object_resolve_externs(struct bpf_object *obj, const char *extra_kconfig)
{
bool need_config = false, need_kallsyms = false;
bool need_vmlinux_btf = false;
@@ -7976,7 +7950,7 @@ static int bpf_object__resolve_externs(struct bpf_object *obj,
}
}
if (need_config && extra_kconfig) {
- err = bpf_object__read_kconfig_mem(obj, extra_kconfig, kcfg_data);
+ err = bpf_object_read_kconfig_mem(obj, extra_kconfig, kcfg_data);
if (err)
return -EINVAL;
need_config = false;
@@ -7989,17 +7963,17 @@ static int bpf_object__resolve_externs(struct bpf_object *obj,
}
}
if (need_config) {
- err = bpf_object__read_kconfig_file(obj, kcfg_data);
+ err = bpf_object_read_kconfig_file(obj, kcfg_data);
if (err)
return -EINVAL;
}
if (need_kallsyms) {
- err = bpf_object__read_kallsyms_file(obj);
+ err = bpf_object_read_kallsyms_file(obj);
if (err)
return -EINVAL;
}
if (need_vmlinux_btf) {
- err = bpf_object__resolve_ksyms_btf_id(obj);
+ err = bpf_object_resolve_ksyms_btf_id(obj);
if (err)
return -EINVAL;
}
@@ -8043,7 +8017,7 @@ static int bpf_object_prepare_struct_ops(struct bpf_object *obj)
int i;
for (i = 0; i < obj->nr_maps; i++)
- if (bpf_map__is_struct_ops(&obj->maps[i]))
+ if (bpf_map_is_struct_ops(&obj->maps[i]))
bpf_map_prepare_vdata(&obj->maps[i]);
return 0;
@@ -8064,15 +8038,15 @@ static int bpf_object_load(struct bpf_object *obj, int extra_log_level, const ch
if (obj->gen_loader)
bpf_gen__init(obj->gen_loader, extra_log_level, obj->nr_programs, obj->nr_maps);
- err = bpf_object__probe_loading(obj);
- err = err ? : bpf_object__load_vmlinux_btf(obj, false);
- err = err ? : bpf_object__resolve_externs(obj, obj->kconfig);
- err = err ? : bpf_object__sanitize_and_load_btf(obj);
- err = err ? : bpf_object__sanitize_maps(obj);
- err = err ? : bpf_object__init_kern_struct_ops_maps(obj);
- err = err ? : bpf_object__create_maps(obj);
- err = err ? : bpf_object__relocate(obj, obj->btf_custom_path ? : target_btf_path);
- err = err ? : bpf_object__load_progs(obj, extra_log_level);
+ err = bpf_object_probe_loading(obj);
+ err = err ? : bpf_object_load_vmlinux_btf(obj, false);
+ err = err ? : bpf_object_resolve_externs(obj, obj->kconfig);
+ err = err ? : bpf_object_sanitize_and_load_btf(obj);
+ err = err ? : bpf_object_sanitize_maps(obj);
+ err = err ? : bpf_object_init_kern_struct_ops_maps(obj);
+ err = err ? : bpf_object_create_maps(obj);
+ err = err ? : bpf_object_relocate(obj, obj->btf_custom_path ? : target_btf_path);
+ err = err ? : bpf_object_load_progs(obj, extra_log_level);
err = err ? : bpf_object_init_prog_arrays(obj);
err = err ? : bpf_object_prepare_struct_ops(obj);
@@ -8530,10 +8504,10 @@ int bpf_object__unpin(struct bpf_object *obj, const char *path)
return 0;
}
-static void bpf_map__destroy(struct bpf_map *map)
+static void bpf_map_destroy(struct bpf_map *map)
{
if (map->inner_map) {
- bpf_map__destroy(map->inner_map);
+ bpf_map_destroy(map->inner_map);
zfree(&map->inner_map);
}
@@ -8574,14 +8548,14 @@ void bpf_object__close(struct bpf_object *obj)
obj->usdt_man = NULL;
bpf_gen__free(obj->gen_loader);
- bpf_object__elf_finish(obj);
+ bpf_object_elf_finish(obj);
bpf_object_unload(obj);
btf__free(obj->btf);
btf__free(obj->btf_vmlinux);
btf_ext__free(obj->btf_ext);
for (i = 0; i < obj->nr_maps; i++)
- bpf_map__destroy(&obj->maps[i]);
+ bpf_map_destroy(&obj->maps[i]);
zfree(&obj->btf_custom_path);
zfree(&obj->kconfig);
@@ -8597,7 +8571,7 @@ void bpf_object__close(struct bpf_object *obj)
if (obj->programs && obj->nr_programs) {
for (i = 0; i < obj->nr_programs; i++)
- bpf_program__exit(&obj->programs[i]);
+ bpf_program_exit(&obj->programs[i]);
}
zfree(&obj->programs);
@@ -8651,8 +8625,8 @@ int bpf_object__gen_loader(struct bpf_object *obj, struct gen_loader_opts *opts)
}
static struct bpf_program *
-__bpf_program__iter(const struct bpf_program *p, const struct bpf_object *obj,
- bool forward)
+bpf_object_prog_iter(const struct bpf_program *p, const struct bpf_object *obj,
+ bool forward)
{
size_t nr_programs = obj->nr_programs;
ssize_t idx;
@@ -8682,7 +8656,7 @@ bpf_object__next_program(const struct bpf_object *obj, struct bpf_program *prev)
struct bpf_program *prog = prev;
do {
- prog = __bpf_program__iter(prog, obj, true);
+ prog = bpf_object_prog_iter(prog, obj, true);
} while (prog && prog_is_subprog(obj, prog));
return prog;
@@ -8694,7 +8668,7 @@ bpf_object__prev_program(const struct bpf_object *obj, struct bpf_program *next)
struct bpf_program *prog = next;
do {
- prog = __bpf_program__iter(prog, obj, false);
+ prog = bpf_object_prog_iter(prog, obj, false);
} while (prog && prog_is_subprog(obj, prog));
return prog;
@@ -9250,7 +9224,7 @@ static struct bpf_map *find_struct_ops_map_by_offset(struct bpf_object *obj,
for (i = 0; i < obj->nr_maps; i++) {
map = &obj->maps[i];
- if (!bpf_map__is_struct_ops(map))
+ if (!bpf_map_is_struct_ops(map))
continue;
if (map->sec_idx == sec_idx &&
map->sec_offset <= offset &&
@@ -9262,8 +9236,8 @@ static struct bpf_map *find_struct_ops_map_by_offset(struct bpf_object *obj,
}
/* Collect the reloc from ELF and populate the st_ops->progs[] */
-static int bpf_object__collect_st_ops_relos(struct bpf_object *obj,
- Elf64_Shdr *shdr, Elf_Data *data)
+static int bpf_object_collect_st_ops_relos(struct bpf_object *obj,
+ Elf64_Shdr *shdr, Elf_Data *data)
{
const struct btf_member *member;
struct bpf_struct_ops *st_ops;
@@ -9850,7 +9824,7 @@ int bpf_map__set_ifindex(struct bpf_map *map, __u32 ifindex)
int bpf_map__set_inner_map_fd(struct bpf_map *map, int fd)
{
- if (!bpf_map_type__is_map_in_map(map->def.type)) {
+ if (!bpf_map_type_is_map_in_map(map->def.type)) {
pr_warn("error: unsupported map type\n");
return libbpf_err(-EINVAL);
}
@@ -9859,7 +9833,7 @@ int bpf_map__set_inner_map_fd(struct bpf_map *map, int fd)
return libbpf_err(-EINVAL);
}
if (map->inner_map) {
- bpf_map__destroy(map->inner_map);
+ bpf_map_destroy(map->inner_map);
zfree(&map->inner_map);
}
map->inner_map_fd = fd;
@@ -9867,7 +9841,7 @@ int bpf_map__set_inner_map_fd(struct bpf_map *map, int fd)
}
static struct bpf_map *
-__bpf_map__iter(const struct bpf_map *m, const struct bpf_object *obj, int i)
+bpf_object_iter_map(const struct bpf_map *m, const struct bpf_object *obj, int i)
{
ssize_t idx;
struct bpf_map *s, *e;
@@ -9896,7 +9870,7 @@ bpf_object__next_map(const struct bpf_object *obj, const struct bpf_map *prev)
if (prev == NULL)
return obj->maps;
- return __bpf_map__iter(prev, obj, 1);
+ return bpf_object_iter_map(prev, obj, 1);
}
struct bpf_map *
@@ -9908,7 +9882,7 @@ bpf_object__prev_map(const struct bpf_object *obj, const struct bpf_map *next)
return obj->maps + obj->nr_maps - 1;
}
- return __bpf_map__iter(next, obj, -1);
+ return bpf_object_iter_map(next, obj, -1);
}
struct bpf_map *
@@ -10117,7 +10091,7 @@ const char *bpf_link__pin_path(const struct bpf_link *link)
return link->pin_path;
}
-static int bpf_link__detach_fd(struct bpf_link *link)
+static int bpf_link_detach_fd(struct bpf_link *link)
{
return libbpf_err_errno(close(link->fd));
}
@@ -10139,7 +10113,7 @@ struct bpf_link *bpf_link__open(const char *path)
close(fd);
return libbpf_err_ptr(-ENOMEM);
}
- link->detach = &bpf_link__detach_fd;
+ link->detach = &bpf_link_detach_fd;
link->fd = fd;
link->pin_path = strdup(path);
@@ -11025,7 +10999,7 @@ bpf_program__attach_kprobe_multi_opts(const struct bpf_program *prog,
err = -ENOMEM;
goto error;
}
- link->detach = &bpf_link__detach_fd;
+ link->detach = &bpf_link_detach_fd;
prog_fd = bpf_program__fd(prog);
link_fd = bpf_link_create(prog_fd, 0, BPF_TRACE_KPROBE_MULTI, &lopts);
@@ -11483,7 +11457,7 @@ bpf_program__attach_uprobe_multi(const struct bpf_program *prog,
err = -ENOMEM;
goto error;
}
- link->detach = &bpf_link__detach_fd;
+ link->detach = &bpf_link_detach_fd;
prog_fd = bpf_program__fd(prog);
link_fd = bpf_link_create(prog_fd, 0, BPF_TRACE_UPROBE_MULTI, &lopts);
@@ -11936,7 +11910,7 @@ struct bpf_link *bpf_program__attach_raw_tracepoint(const struct bpf_program *pr
link = calloc(1, sizeof(*link));
if (!link)
return libbpf_err_ptr(-ENOMEM);
- link->detach = &bpf_link__detach_fd;
+ link->detach = &bpf_link_detach_fd;
pfd = bpf_raw_tracepoint_open(tp_name, prog_fd);
if (pfd < 0) {
@@ -11992,8 +11966,8 @@ static int attach_raw_tp(const struct bpf_program *prog, long cookie, struct bpf
}
/* Common logic for all BPF program types that attach to a btf_id */
-static struct bpf_link *bpf_program__attach_btf_id(const struct bpf_program *prog,
- const struct bpf_trace_opts *opts)
+static struct bpf_link *bpf_program_attach_btf_id(const struct bpf_program *prog,
+ const struct bpf_trace_opts *opts)
{
LIBBPF_OPTS(bpf_link_create_opts, link_opts);
char errmsg[STRERR_BUFSIZE];
@@ -12012,7 +11986,7 @@ static struct bpf_link *bpf_program__attach_btf_id(const struct bpf_program *pro
link = calloc(1, sizeof(*link));
if (!link)
return libbpf_err_ptr(-ENOMEM);
- link->detach = &bpf_link__detach_fd;
+ link->detach = &bpf_link_detach_fd;
/* libbpf is smart enough to redirect to BPF_RAW_TRACEPOINT_OPEN on old kernels */
link_opts.tracing.cookie = OPTS_GET(opts, cookie, 0);
@@ -12030,18 +12004,18 @@ static struct bpf_link *bpf_program__attach_btf_id(const struct bpf_program *pro
struct bpf_link *bpf_program__attach_trace(const struct bpf_program *prog)
{
- return bpf_program__attach_btf_id(prog, NULL);
+ return bpf_program_attach_btf_id(prog, NULL);
}
struct bpf_link *bpf_program__attach_trace_opts(const struct bpf_program *prog,
const struct bpf_trace_opts *opts)
{
- return bpf_program__attach_btf_id(prog, opts);
+ return bpf_program_attach_btf_id(prog, opts);
}
struct bpf_link *bpf_program__attach_lsm(const struct bpf_program *prog)
{
- return bpf_program__attach_btf_id(prog, NULL);
+ return bpf_program_attach_btf_id(prog, NULL);
}
static int attach_trace(const struct bpf_program *prog, long cookie, struct bpf_link **link)
@@ -12075,7 +12049,7 @@ bpf_program_attach_fd(const struct bpf_program *prog,
link = calloc(1, sizeof(*link));
if (!link)
return libbpf_err_ptr(-ENOMEM);
- link->detach = &bpf_link__detach_fd;
+ link->detach = &bpf_link_detach_fd;
attach_type = bpf_program__expected_attach_type(prog);
link_fd = bpf_link_create(prog_fd, target_fd, attach_type, opts);
@@ -12240,7 +12214,7 @@ bpf_program__attach_iter(const struct bpf_program *prog,
link = calloc(1, sizeof(*link));
if (!link)
return libbpf_err_ptr(-ENOMEM);
- link->detach = &bpf_link__detach_fd;
+ link->detach = &bpf_link_detach_fd;
link_fd = bpf_link_create(prog_fd, target_fd, BPF_TRACE_ITER,
&link_create_opts);
@@ -12281,7 +12255,7 @@ struct bpf_link *bpf_program__attach_netfilter(const struct bpf_program *prog,
if (!link)
return libbpf_err_ptr(-ENOMEM);
- link->detach = &bpf_link__detach_fd;
+ link->detach = &bpf_link_detach_fd;
lopts.netfilter.pf = OPTS_GET(opts, pf, 0);
lopts.netfilter.hooknum = OPTS_GET(opts, hooknum, 0);
@@ -12331,7 +12305,7 @@ struct bpf_link_struct_ops {
int map_fd;
};
-static int bpf_link__detach_struct_ops(struct bpf_link *link)
+static int bpf_link_detach_struct_ops(struct bpf_link *link)
{
struct bpf_link_struct_ops *st_link;
__u32 zero = 0;
@@ -12351,7 +12325,7 @@ struct bpf_link *bpf_map__attach_struct_ops(const struct bpf_map *map)
__u32 zero = 0;
int err, fd;
- if (!bpf_map__is_struct_ops(map) || map->fd == -1)
+ if (!bpf_map_is_struct_ops(map) || map->fd == -1)
return libbpf_err_ptr(-EINVAL);
link = calloc(1, sizeof(*link));
@@ -12370,7 +12344,7 @@ struct bpf_link *bpf_map__attach_struct_ops(const struct bpf_map *map)
return libbpf_err_ptr(err);
}
- link->link.detach = bpf_link__detach_struct_ops;
+ link->link.detach = bpf_link_detach_struct_ops;
if (!(map->def.map_flags & BPF_F_LINK)) {
/* w/o a real link */
@@ -12400,7 +12374,7 @@ int bpf_link__update_map(struct bpf_link *link, const struct bpf_map *map)
__u32 zero = 0;
int err;
- if (!bpf_map__is_struct_ops(map) || map->fd < 0)
+ if (!bpf_map_is_struct_ops(map) || map->fd < 0)
return -EINVAL;
st_ops_link = container_of(link, struct bpf_link_struct_ops, link);
@@ -12517,8 +12491,7 @@ struct perf_buffer {
int map_fd; /* BPF_MAP_TYPE_PERF_EVENT_ARRAY BPF map FD */
};
-static void perf_buffer__free_cpu_buf(struct perf_buffer *pb,
- struct perf_cpu_buf *cpu_buf)
+static void perf_buffer_free_cpu_buf(struct perf_buffer *pb, struct perf_cpu_buf *cpu_buf)
{
if (!cpu_buf)
return;
@@ -12547,7 +12520,7 @@ void perf_buffer__free(struct perf_buffer *pb)
continue;
bpf_map_delete_elem(pb->map_fd, &cpu_buf->map_key);
- perf_buffer__free_cpu_buf(pb, cpu_buf);
+ perf_buffer_free_cpu_buf(pb, cpu_buf);
}
free(pb->cpu_bufs);
}
@@ -12558,8 +12531,8 @@ void perf_buffer__free(struct perf_buffer *pb)
}
static struct perf_cpu_buf *
-perf_buffer__open_cpu_buf(struct perf_buffer *pb, struct perf_event_attr *attr,
- int cpu, int map_key)
+perf_buffer_open_cpu_buf(struct perf_buffer *pb, struct perf_event_attr *attr,
+ int cpu, int map_key)
{
struct perf_cpu_buf *cpu_buf;
char msg[STRERR_BUFSIZE];
@@ -12603,12 +12576,12 @@ perf_buffer__open_cpu_buf(struct perf_buffer *pb, struct perf_event_attr *attr,
return cpu_buf;
error:
- perf_buffer__free_cpu_buf(pb, cpu_buf);
+ perf_buffer_free_cpu_buf(pb, cpu_buf);
return (struct perf_cpu_buf *)ERR_PTR(err);
}
-static struct perf_buffer *__perf_buffer__new(int map_fd, size_t page_cnt,
- struct perf_buffer_params *p);
+static struct perf_buffer *perf_buffer_new(int map_fd, size_t page_cnt,
+ struct perf_buffer_params *p);
struct perf_buffer *perf_buffer__new(int map_fd, size_t page_cnt,
perf_buffer_sample_fn sample_cb,
@@ -12641,7 +12614,7 @@ struct perf_buffer *perf_buffer__new(int map_fd, size_t page_cnt,
p.lost_cb = lost_cb;
p.ctx = ctx;
- return libbpf_ptr(__perf_buffer__new(map_fd, page_cnt, &p));
+ return libbpf_ptr(perf_buffer_new(map_fd, page_cnt, &p));
}
struct perf_buffer *perf_buffer__new_raw(int map_fd, size_t page_cnt,
@@ -12664,11 +12637,11 @@ struct perf_buffer *perf_buffer__new_raw(int map_fd, size_t page_cnt,
p.cpus = OPTS_GET(opts, cpus, NULL);
p.map_keys = OPTS_GET(opts, map_keys, NULL);
- return libbpf_ptr(__perf_buffer__new(map_fd, page_cnt, &p));
+ return libbpf_ptr(perf_buffer_new(map_fd, page_cnt, &p));
}
-static struct perf_buffer *__perf_buffer__new(int map_fd, size_t page_cnt,
- struct perf_buffer_params *p)
+static struct perf_buffer *perf_buffer_new(int map_fd, size_t page_cnt,
+ struct perf_buffer_params *p)
{
const char *online_cpus_file = "/sys/devices/system/cpu/online";
struct bpf_map_info map;
@@ -12773,7 +12746,7 @@ static struct perf_buffer *__perf_buffer__new(int map_fd, size_t page_cnt,
if (p->cpu_cnt <= 0 && (cpu >= n || !online[cpu]))
continue;
- cpu_buf = perf_buffer__open_cpu_buf(pb, p->attr, cpu, map_key);
+ cpu_buf = perf_buffer_open_cpu_buf(pb, p->attr, cpu, map_key);
if (IS_ERR(cpu_buf)) {
err = PTR_ERR(cpu_buf);
goto error;
@@ -12828,8 +12801,7 @@ struct perf_sample_lost {
uint64_t sample_id;
};
-static enum bpf_perf_event_ret
-perf_buffer__process_record(struct perf_event_header *e, void *ctx)
+static enum bpf_perf_event_ret perf_buffer_process_record(struct perf_event_header *e, void *ctx)
{
struct perf_cpu_buf *cpu_buf = ctx;
struct perf_buffer *pb = cpu_buf->pb;
@@ -12861,15 +12833,15 @@ perf_buffer__process_record(struct perf_event_header *e, void *ctx)
return LIBBPF_PERF_EVENT_CONT;
}
-static int perf_buffer__process_records(struct perf_buffer *pb,
- struct perf_cpu_buf *cpu_buf)
+static int perf_buffer_process_records(struct perf_buffer *pb,
+ struct perf_cpu_buf *cpu_buf)
{
enum bpf_perf_event_ret ret;
ret = perf_event_read_simple(cpu_buf->base, pb->mmap_size,
pb->page_size, &cpu_buf->buf,
&cpu_buf->buf_size,
- perf_buffer__process_record, cpu_buf);
+ perf_buffer_process_record, cpu_buf);
if (ret != LIBBPF_PERF_EVENT_CONT)
return ret;
return 0;
@@ -12891,7 +12863,7 @@ int perf_buffer__poll(struct perf_buffer *pb, int timeout_ms)
for (i = 0; i < cnt; i++) {
struct perf_cpu_buf *cpu_buf = pb->events[i].data.ptr;
- err = perf_buffer__process_records(pb, cpu_buf);
+ err = perf_buffer_process_records(pb, cpu_buf);
if (err) {
pr_warn("error while processing records: %d\n", err);
return libbpf_err(err);
@@ -12962,7 +12934,7 @@ int perf_buffer__consume_buffer(struct perf_buffer *pb, size_t buf_idx)
if (!cpu_buf)
return libbpf_err(-ENOENT);
- return perf_buffer__process_records(pb, cpu_buf);
+ return perf_buffer_process_records(pb, cpu_buf);
}
int perf_buffer__consume(struct perf_buffer *pb)
@@ -12975,7 +12947,7 @@ int perf_buffer__consume(struct perf_buffer *pb)
if (!cpu_buf)
continue;
- err = perf_buffer__process_records(pb, cpu_buf);
+ err = perf_buffer_process_records(pb, cpu_buf);
if (err) {
pr_warn("perf_buffer: failed to process records in buffer #%d: %d\n", i, err);
return libbpf_err(err);
@@ -12997,7 +12969,7 @@ int bpf_program__set_attach_target(struct bpf_program *prog,
return libbpf_err(-EINVAL);
if (attach_prog_fd && !attach_func_name) {
- /* remember attach_prog_fd and let bpf_program__load() find
+ /* remember attach_prog_fd and let bpf_object_load_prog() find
* BTF ID during the program load
*/
prog->attach_prog_fd = attach_prog_fd;
@@ -13014,7 +12986,7 @@ int bpf_program__set_attach_target(struct bpf_program *prog,
return libbpf_err(-EINVAL);
/* load btf_vmlinux, if not yet */
- err = bpf_object__load_vmlinux_btf(prog->obj, true);
+ err = bpf_object_load_vmlinux_btf(prog->obj, true);
if (err)
return libbpf_err(err);
err = find_kernel_btf_id(prog->obj, attach_func_name,
--
2.34.1
