On Tue Dec 12 2023, YiFei Zhu wrote: >> > diff --git a/tools/testing/selftests/bpf/prog_tests/time_tai.c b/tools/testing/selftests/bpf/prog_tests/time_tai.c >> > index a31119823666..f45af1b0ef2c 100644 >> > --- a/tools/testing/selftests/bpf/prog_tests/time_tai.c >> > +++ b/tools/testing/selftests/bpf/prog_tests/time_tai.c >> > @@ -56,7 +56,7 @@ void test_time_tai(void) >> > ASSERT_NEQ(ts2, 0, "tai_ts2"); >> > >> > /* TAI is moving forward only */ >> > - ASSERT_GT(ts2, ts1, "tai_forward"); >> > + ASSERT_GE(ts2, ts1, "tai_forward"); >> >> Can we guard the new change with arm64 specific macro? > > Problem with this is that I'm not sure what other architectures could > be affected. AFAICT from the test, what it cares about is that time is > moving forwards rather than going backwards, so I thought GE is good > enough for what it's testing for. Yes, exactly. The time must not go backwards. Checking for GE is fine. Thanks for fixing this.
Attachment:
signature.asc
Description: PGP signature
