Yafang Shao <laoar.shao@xxxxxxxxx> writes:
> MPOL_F_STATIC_NODES, MPOL_F_RELATIVE_NODES, and MPOL_F_NUMA_BALANCING are
> mode flags applicable to both set_mempolicy(2) and mbind(2) system calls.
> It's worth noting that MPOL_F_NUMA_BALANCING was initially introduced in
> commit bda420b98505 ("numa balancing: migrate on fault among multiple bound
> nodes") exclusively for set_mempolicy(2). However, it was later made a
> shared flag for both set_mempolicy(2) and mbind(2) following
> commit 6d2aec9e123b ("mm/mempolicy: do not allow illegal
> MPOL_F_NUMA_BALANCING | MPOL_LOCAL in mbind()").
>
> This revised version aims to clarify the details regarding the mode flags.
>
> Signed-off-by: Yafang Shao <laoar.shao@xxxxxxxxx>
> Cc: Eric Dumazet <edumazet@xxxxxxxxxx>
> Cc: "Huang, Ying" <ying.huang@xxxxxxxxx>
Thanks for fixing this.
Reviewed-by: "Huang, Ying" <ying.huang@xxxxxxxxx>
And, please revise the manpage for mbind() too. As we have done for
set_mempolicy(),
https://lore.kernel.org/all/20210120061235.148637-3-ying.huang@xxxxxxxxx/
--
Best Regards,
Huang, Ying
> ---
> include/uapi/linux/mempolicy.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/mempolicy.h b/include/uapi/linux/mempolicy.h
> index a8963f7ef4c2..afed4a45f5b9 100644
> --- a/include/uapi/linux/mempolicy.h
> +++ b/include/uapi/linux/mempolicy.h
> @@ -26,7 +26,7 @@ enum {
> MPOL_MAX, /* always last member of enum */
> };
>
> -/* Flags for set_mempolicy */
> +/* Flags for set_mempolicy() or mbind() */
> #define MPOL_F_STATIC_NODES (1 << 15)
> #define MPOL_F_RELATIVE_NODES (1 << 14)
> #define MPOL_F_NUMA_BALANCING (1 << 13) /* Optimize with NUMA balancing if possible */
