On Thu, Oct 3, 2019 at 3:52 AM Björn Töpel <bjorn.topel@xxxxxxxxx> wrote: > > On Thu, 3 Oct 2019 at 12:37, Masahiro Yamada > <yamada.masahiro@xxxxxxxxxxxxx> wrote: > > > > On Thu, Oct 3, 2019 at 3:28 PM Björn Töpel <bjorn.topel@xxxxxxxxx> wrote: > > > > > > On Thu, 3 Oct 2019 at 01:14, Ivan Khoronzhuk <ivan.khoronzhuk@xxxxxxxxxx> wrote: > > > > > > > > On Wed, Oct 02, 2019 at 09:41:15AM +0200, Björn Töpel wrote: > > > > >On Wed, 2 Oct 2019 at 03:49, Masahiro Yamada > > > > ><yamada.masahiro@xxxxxxxxxxxxx> wrote: > > > > >> > > > > >[...] > > > > >> > Yes, the BPF samples require clang/LLVM with BPF support to build. Any > > > > >> > suggestion on a good way to address this (missing tools), better than > > > > >> > the warning above? After the commit 394053f4a4b3 ("kbuild: make single > > > > >> > targets work more correctly"), it's no longer possible to build > > > > >> > samples/bpf without support in the samples/Makefile. > > > > >> > > > > >> > > > > >> You can with > > > > >> > > > > >> "make M=samples/bpf" > > > > >> > > > > > > > > > >Oh, I didn't know that. Does M= support "output" builds (O=)? > > > > No. > > O= points to the output directory of vmlinux, > > not of the external module. > > > > You cannot put the build artifacts from samples/bpf/ > > in a separate directory. > > > > Hmm, I can't even get "make M=samples/bpf/" to build. Am I missing > something obvious? There were 3 or 4 separate fixes submitted for samples/bpf yesterday, maybe you are hitting some of those issues. Try to pull latest (not sure if bpf or bpf-next tree). I tried make M=samples/bpf and it worked for me. > > Prior 394053f4a4b3 "make samples/bpf/" and "make O=/foo/bar > samples/bpf/" worked, but I guess I can live with that... > > > Thanks! > Björn > > > > > > > > > > >I usually just build samples/bpf/ with: > > > > > > > > > > $ make V=1 O=/home/foo/build/bleh samples/bpf/ > > > > > > > > > > > > > > >Björn > > > > > > > > Shouldn't README be updated? > > > > > > > > > > Hmm, the M= variant doesn't work at all for me. The build is still > > > broken for me. Maybe I'm missing anything obvious... > > > > > > > > > > -- > > > > Regards, > > > > Ivan Khoronzhuk > > > > > > > > -- > > Best Regards > > Masahiro Yamada