On Tue, Oct 01, 2019 at 08:42:30PM -0700, Brian Vazquez wrote: > Thanks for reviewing the patches Andrii! > > Although Daniel fixed them and applied them correctly. After last kernel/maintainer summit at LPC, I reworked all my patchwork scripts [0] which I use for bpf trees in order to further reduce manual work and add more sanity checks at the same time. Therefore, the broken Fixes: tag was a good test-case. ;-) Thanks, Daniel [0] https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/pw.git/ > On Tue, Oct 1, 2019 at 8:20 PM Andrii Nakryiko > <andrii.nakryiko@xxxxxxxxx> wrote: > > > > On Tue, Oct 1, 2019 at 10:40 AM Brian Vazquez <brianvv@xxxxxxxxxx> wrote: > > > > > > > I don't think there is a need to add "test_progs:" to subject, " > > test_sockopt_inherit" is specific enough ;) > > > > > server_fd needs to be close if pthread can't be created. > > > > typo: closed > > > > > Fixes: e3e02e1d9c24 ("selftests/bpf: test_progs: convert test_sockopt_inherit") > > > Cc: Stanislav Fomichev <sdf@xxxxxxxxxx> > > > Signed-off-by: Brian Vazquez <brianvv@xxxxxxxxxx> > > > --- > > > > Acked-by: Andrii Nakryiko <andriin@xxxxxx> > > > > > tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-)
