On Tue, Oct 1, 2019 at 10:40 AM Brian Vazquez <brianvv@xxxxxxxxxx> wrote:
>
I don't think there is a need to add "test_progs:" to subject, "
test_sockopt_inherit" is specific enough ;)
> server_fd needs to be close if pthread can't be created.
typo: closed
>
> Fixes: e3e02e1d9c24 ("selftests/bpf: test_progs: convert test_sockopt_inherit")
> Cc: Stanislav Fomichev <sdf@xxxxxxxxxx>
> Signed-off-by: Brian Vazquez <brianvv@xxxxxxxxxx>
> ---
Acked-by: Andrii Nakryiko <andriin@xxxxxx>
> tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c b/tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c
> index 6cbeea7b4bf16..8547ecbdc61ff 100644
> --- a/tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c
> +++ b/tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c
> @@ -195,7 +195,7 @@ static void run_test(int cgroup_fd)
>
> if (CHECK_FAIL(pthread_create(&tid, NULL, server_thread,
> (void *)&server_fd)))
> - goto close_bpf_object;
> + goto close_server_fd;
>
> pthread_mutex_lock(&server_started_mtx);
> pthread_cond_wait(&server_started, &server_started_mtx);
> --
> 2.23.0.444.g18eeb5a265-goog
>
