On Tue, Jun 25, 2019 at 5:09 AM Jesper Dangaard Brouer <brouer@xxxxxxxxxx> wrote: > > On Tue, 25 Jun 2019 11:08:22 +0200 > Toke Høiland-Jørgensen <toke@xxxxxxxxxx> wrote: > > > "Daniel T. Lee" <danieltimlee@xxxxxxxxx> writes: > > > > > Currently, each xdp samples are inconsistent in the use. > > > Most of the samples fetch the interface with it's name. > > > (ex. xdp1, xdp2skb, xdp_redirect_cpu, xdp_sample_pkts, etc.) > > > > > > But some of the xdp samples are fetching the interface with > > > ifindex by command argument. > > > > > > This commit enables xdp samples to fetch interface with it's name > > > without changing the original index interface fetching. > > > (<ifname|ifindex> fetching in the same way as xdp_sample_pkts_user.c does.) > > > > > > Signed-off-by: Daniel T. Lee <danieltimlee@xxxxxxxxx> Acked-by: Song Liu <songliubraving@xxxxxx> > > > --- > > > Changes in v2: > > > - added xdp_redirect_user.c, xdp_redirect_map_user.c > > > > Great, thanks! > > > > Acked-by: Toke Høiland-Jørgensen <toke@xxxxxxxxxx> > > Great you basically solved one of our TODOs: > - TODO Change sample programs to accept ifnames as well as indexes > > https://github.com/xdp-project/xdp-project/blob/master/xdp-project.org#next-change-sample-programs-to-accept-ifnames-as-well-as-indexes > > Acked-by: Jesper Dangaard Brouer <brouer@xxxxxxxxxx> > > -- > Best regards, > Jesper Dangaard Brouer > MSc.CS, Principal Kernel Engineer at Red Hat > LinkedIn: http://www.linkedin.com/in/brouer
