Re: [PATCH 03/11] xdp: add offset param to zero_copy_allocator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 24/06/2019 20:23, Jakub Kicinski wrote:
On Thu, 20 Jun 2019 09:09:50 +0000, Kevin Laatz wrote:
diff --git a/include/net/xdp.h b/include/net/xdp.h
index 0f25b3675c5c..ea801fd2bf98 100644
--- a/include/net/xdp.h
+++ b/include/net/xdp.h
@@ -53,7 +53,8 @@ struct xdp_mem_info {
 struct page_pool;

 struct zero_copy_allocator {
-    void (*free)(struct zero_copy_allocator *zca, unsigned long handle);
+    void (*free)(struct zero_copy_allocator *zca, unsigned long handle,
+            off_t off);
 };

Please run checkpatch --strict on all your changes.  The code
formatting is incorrect in many ways in this series.

Thanks, will fix in the v2.


Please include performance measurements proving the slow down
is negligible in the cover letter.

Good suggestion. Will add to the cover letter in the v2!



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux