On Fri, 2008-06-27 at 15:05 -0400, Michael Terry wrote: > Hello, all! > > I have attached a patch against 0.27 (it applies cleanly against CVS) to > complete the wizard in the bluez-gnome source tree. - item = gtk_menu_item_new_with_label(_("Setup New Device")); + item = gtk_menu_item_new_with_label(_("Connect New Device...")); This is wrong, as we'll probably want to plug in more setup for future device types. For example, when adding a phone, we'll want to check whether it supports SyncML, and automatically set it up in the sync program. The setup_services() service call shouldn't be needed, as all the services are enabled by default. In bluetooth_client_available_services(), you also need to add joypads, and every other input devices to that list. + // If caller didn't specify a forced type, determine it from device info Don't use C++-style comments. I personally don't really like adding setup calls in client.c, which should really only be used for discovery. The rest looks alright to me, looking over it quickly. Cheers ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Bluez-devel mailing list Bluez-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/bluez-devel