On 2018/05/09 17:12, Johannes Berg wrote:
Though of course this doesn't apply to the older branches :)
How about setting upper limitation to the older branches by attached patch ? Masashi Honma.
diff --git a/lib/bpreqs.py b/lib/bpreqs.py index 1325fd2..feef444 100644 --- a/lib/bpreqs.py +++ b/lib/bpreqs.py @@ -190,10 +190,11 @@ class Req: sys.stdout.write("Try installing the package: %s\n" % package_hint) return False def coccinelle(self, version): - if self.require_version('spatch', '--version', version, 2, self.linux_version_cmp): + if self.linux_version_cmp('1.0.6', self.req_get_prog_version('spatch', '--version', 2)) == -1 and \ + self.require_version('spatch', '--version', version, 2, self.linux_version_cmp): return True sys.stdout.write("Try installing the package: coccinelle\n") - sys.stdout.write("If that is too old go grab the code from source:\n\n") + sys.stdout.write("If that is less than " + version + " or more than 1.0.6 go grab the code from source:\n\n") sys.stdout.write("git clone https://github.com/coccinelle/coccinelle.git\n\n") sys.stdout.write("To build you will need: ocaml ncurses-devel\n\n") sys.stdout.write("If on SUSE / OpenSUSE you will also need: ocaml-ocamldoc\n\n")