Re: [PATCH] gentree: create Kconfig.local, use it to restrict compat

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 12-9-2016 11:17, Arend Van Spriel wrote:
> On 29-8-2016 19:51, Johannes Berg wrote:
>> From: Johannes Berg <johannes.berg@xxxxxxxxx>
>>
>> Not all the compat code is always necessary, for example code
>> enabled by BPAUTO_CRYPTO_SKCIPHER and by BPAUTO_RHASHTABLE is
>> gated on other symbols being selected. Checking against the
>> Kconfig symbols as it's done right now is wrong though, since
>> the base kernel's Kconfig symbols would be used, selecting,
>> for example, BPAUTO_CRYPTO_SKCIPHER when the base kernel has
>> CONFIG_BT set, but doing that when BT isn't even part of the
>> backport, or when it's disabled in the backport.
> 
> Excellent. Thanks for this. I have been spending some time on fixing
> that skcipher stuff (attached) although the stuff in my selective
> backport does not need it.

For people considering the patch please be warned that I did not
actually test it. I added two structures, but did not verify if those
are the same for kernel versions 3.0 to 4.8. For struct
skcipher_instance a .init field was added so that at least needs to be
fixed.

Regards,
Arend
--
To unsubscribe from this list: send the line "unsubscribe backports" in



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux