On Fri, 2013-08-16 at 20:04 +0200, Hauke Mehrtens wrote: > This is done to eliminate these warnings: Fair enough. > I do not like this whole patch that much, do you have a better idea to > backport this change: > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=f0bc99c84349ce87af5b35839d19bfb17bb9b27f I played with it a bit, and came up with this: http://p.sipsolutions.net/e3140c53fb57f9ed.txt It has the small advantage that the patch is smaller and doesn't need to know about the attributes ... A disadvantage is the runtime overhead on module load and the extra memory. As we discussed on IRC, the #else part is only needed to not have to #ifdef the init_ieee80211_attrs() call, it might very well be better to ifdef that and get rid of the #else part to avoid having to copy part of the ATTRIBUTE_GROUPS definition. Not really sure. johannes -- To unsubscribe from this list: send the line "unsubscribe backports" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
