On 08/16/2013 07:35 PM, Johannes Berg wrote: > On Fri, 2013-08-16 at 19:26 +0200, Hauke Mehrtens wrote: >> >> +#if LINUX_VERSION_CODE < KERNEL_VERSION(3,11,0) >> +#define BUS_ATTR_RW(_name) >> +#define BUS_ATTR_RO(_name) >> +#define DRIVER_ATTR_RW(_name) >> +#define DRIVER_ATTR_RO(_name) >> +#define CLASS_ATTR_RW(_name) >> +#define CLASS_ATTR_RO(_name) >> +#define DEVICE_ATTR_RW(_name) >> +#define DEVICE_ATTR_RO(_name) >> +#endif > > Is that part really helpful? Seems you'd want it to fail, or am I > misunderstanding it? > > johannes > This is done to eliminate these warnings: /net/wireless/sysfs.c:36:1: warning: type defaults to ‘int’ in declaration of ‘DEVICE_ATTR_RO’ [-Wimplicit-int] /net/wireless/sysfs.c:36:1: warning: parameter names (without types) in function declaration [enabled by default] /net/wireless/sysfs.c:37:1: warning: type defaults to ‘int’ in declaration of ‘DEVICE_ATTR_RO’ [-Wimplicit-int] /net/wireless/sysfs.c:37:1: warning: parameter names (without types) in function declaration [enabled by default] /net/wireless/sysfs.c:38:1: warning: type defaults to ‘int’ in declaration of ‘DEVICE_ATTR_RO’ [-Wimplicit-int] /net/wireless/sysfs.c:38:1: warning: parameter names (without types) in function declaration [enabled by default] /net/wireless/sysfs.c:46:8: warning: type defaults to ‘int’ in declaration of ‘DEVICE_ATTR_RO’ [-Wimplicit-int] /net/wireless/sysfs.c:46:1: warning: parameter names (without types) in function declaration [enabled by default] /net/wireless/sysfs.c:64:8: warning: type defaults to ‘int’ in declaration of ‘DEVICE_ATTR_RO’ [-Wimplicit-int] /net/wireless/sysfs.c:64:1: warning: parameter names (without types) in function declaration [enabled by default] /net/wireless/sysfs.c:64:8: warning: ‘DEVICE_ATTR_RO’ declared ‘static’ but never defined [-Wunused-function] With this change I get an other warning. ;-) I do not like this whole patch that much, do you have a better idea to backport this change: https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=f0bc99c84349ce87af5b35839d19bfb17bb9b27f Hauke -- To unsubscribe from this list: send the line "unsubscribe backports" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
