On Wed, 2013-04-03 at 13:31 +0200, Johannes Berg wrote: > On Tue, 2013-04-02 at 21:32 -0700, Luis R. Rodriguez wrote: > > > --- a/backport/compat/Kconfig > > +++ b/backport/compat/Kconfig > > @@ -118,6 +118,16 @@ config BACKPORT_BUILD_DMA_SHARED_BUFFER > > config BACKPORT_DMA_SHARED_BUFFER > > bool > > > > +config BACKPORT_BUILD_HDMI > > + bool > > + depends on !BACKPORT_KERNEL_3_0 > > + default y if BACKPORT_KERNEL_3_9 > > + default y if BACKPORT_USERSEL_BUILD_ALL > > + default y if !HDMI && BACKPORT_HDMI > > You enable this if HDMI wasn't supported in the base kernel and if it's > needed (or build-all selected), but why also if the kernel is < 3.9? It > seems it should be something like > > default y if (!HDMI || BACKPORT_KERNEL_3_9) && BACKPORT_HDMI > > to basically make it ignore the HDMI symbol in kernels < 3.9? Or like for the dmabuf stuff: config BACKPORT_BUILD_HDMI bool # not possible on kernel < 3.0 depends on !BACKPORT_KERNEL_3_0 # don't build if base kernel has it, except on kernel < 3.9 depends on !HDMI || BACKPORT_KERNEL_3_9 # build for testing default y if BACKPORT_USERSEL_BUILDALL # build if a driver needs it default y if BACKPORT_HDMI I think that's more expressive as to what we want here? (maybe we should actually have the comments in there) johannes -- To unsubscribe from this list: send the line "unsubscribe backports" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
