Re: [PATCH 2/2] compat: add HDMI library support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2013-04-02 at 21:32 -0700, Luis R. Rodriguez wrote:

> --- a/backport/compat/Kconfig
> +++ b/backport/compat/Kconfig
> @@ -118,6 +118,16 @@ config BACKPORT_BUILD_DMA_SHARED_BUFFER
>  config BACKPORT_DMA_SHARED_BUFFER
>  	bool
>  
> +config BACKPORT_BUILD_HDMI
> +	bool
> +	depends on !BACKPORT_KERNEL_3_0
> +	default y if BACKPORT_KERNEL_3_9
> +	default y if BACKPORT_USERSEL_BUILD_ALL
> +	default y if !HDMI && BACKPORT_HDMI

You enable this if HDMI wasn't supported in the base kernel and if it's
needed (or build-all selected), but why also if the kernel is < 3.9? It
seems it should be something like

default y if (!HDMI || BACKPORT_KERNEL_3_9) && BACKPORT_HDMI

to basically make it ignore the HDMI symbol in kernels < 3.9?



Btw, I had an idea for doing things like this automatically -- we
actually know which symbols need to be changed to
LINUX_BACKPORT(symbol): all the ones that are exported of course, so
grep for "EXPORT_SYMBOL(_GPL)?" in the sources. It's still tricky, but
we could consider trying it next time.

johannes

--
To unsubscribe from this list: send the line "unsubscribe backports" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux