On Mon, 2021-08-09 at 13:42 +0000, Sietse van Zanen wrote: > > If you're already aware and will relwase an update soon there's nothing > more to do. Glibc 2.34 is not even a week old. I noticed that a few > packages were running into this so I thought I'd notify their > maintainers. I'll commit the change fairly soon and I hope I'll be able to post a release by the end of the month. Florian Weimer logged a Fedora (and RHEL) bug for this, so being made aware of it I fixed it straight away, ;) There is a got-cha though. The reason automount played with the stack size was to work around a bug in glibc when getting really large group info. This was fixed in glibc in 2015 so I don't want to add checks for glibc version since I can't know if a glibc in use has been patched even though it's an old version and because it was fixed quite a while ago. So if anyone tries to build on a distro. with a really old glibc and really large groups info. needs to be handled the advice will be to update glibc, ;) Ian > > -Sietse > > ________________________________ > From: Ian Kent <raven@xxxxxxxxxx> > Sent: Saturday, August 7, 2021 06:44 > To: Sietse van Zanen; autofs@xxxxxxxxxxxxxxx > Subject: Re: autofs & glibc 2.34 > > On Fri, 2021-08-06 at 12:46 +0000, Sietse van Zanen wrote: > > Autofs no longer compiles with newest glibc 2.34. From the changelog: > > > > When _DYNAMIC_STACK_SIZE_SOURCE or _GNU_SOURCE are defined, > > PTHREAD_STACK_MIN is no longer constant and is redefined to > > sysconf(_SC_THREAD_STACK_MIN). This supports dynamic sized register > > sets for modern architectural features like Arm SVE. > > > > > > This is causing compilation error in daemon/automount.c line 87: > > > > size_t detached_thread_stack_size = PTHREAD_STACK_MIN * 144; > > > > > > I'm aware of this. > > What would you like me to to do here? > > I have two patches for this but haven't pushed them to the repo. yet. > Also there will be a release, probably later this month that will > include these. > > Ian > > >
