On Sun, 2019-01-13 at 09:06 +0800, Ian Kent wrote: > On Sat, 2019-01-12 at 09:15 -0600, Goldwyn Rodrigues wrote: > > On 8:23 12/01, Ian Kent wrote: > > > > > > > > > > > However, this would allow mount from "proto=tcp" for an IPv6 > > > > addressed server. > > > > > > This statement is a bit confusing, Isn't this the point of the > > > change? > > > > > > > Yes, I was mentioning the side-effects of the patch :) > > Yeah, I got that after reading it a couple of times, ;) > > Looking at my description for commit 90532146bc I'm not sure > this matters because it says I'm supposed to be checking the > case where proto=(tcp6|udp6) has been specified. > > Maybe it would be better to just return success if neither > tcp6 or udp6 has been specified, I'll have another look at > your original patch to see if that's essentially what it > does. Since there's no way to determine if proto=(udp|tcp) has explicitly been given as a mount option that can't be checked in this function (yet) so your patch is enough. Whether changes are needed to be able to check that is a separate question that I'd rather not think about unless it's actually needed. I'll add your patch to my patch queue, including the comment about "proto=tcp", since it might be a useful hint later on. As usual, due to my process, it will probably be a while before it actually gets committed. If there is some reason the patch needs to be available on kernel.org let me know and I'll do the commit and post. Ian
