On Fri, 2019-01-11 at 12:18 -0600, Goldwyn Rodrigues wrote:
> When an NFS server is specified by an IPv6 address and no mount
> options, the mount fails because check_address_proto()
> receives vers with TCP_REQUESTED set but the host.addr_len is
> INET6_ADDRSTRLEN. Removing the check for INET_ADDRSTRLEN
> fixes this issue.
Thanks for the patch Goldwyn.
Shouldn't that be "Removing the check for INET6_ADDRSTRLEN fixes
this issue".
>
> However, this would allow mount from "proto=tcp" for an IPv6
> addressed server.
This statement is a bit confusing, Isn't this the point of the
change?
I need to try and find the reason I added this check in the
first place to work out if removing the check could introduce
a problem ...
>
> Fixes: 9053214 ("autofs-5.1.3 - fix ipv6 proto option handling")
Can I have a look at the bug, couldn't find it by searching for
it?
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@xxxxxxxx>
> ---
> modules/replicated.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/modules/replicated.c b/modules/replicated.c
> index 740270e..e99e32a 100644
> --- a/modules/replicated.c
> +++ b/modules/replicated.c
> @@ -497,9 +497,6 @@ static int check_address_proto(unsigned logopt,
> if (ipv6_requested) {
> if (host->addr_len == INET_ADDRSTRLEN)
> ret = 0;
> - } else {
> - if (host->addr_len == INET6_ADDRSTRLEN)
> - ret = 0;
> }
>
> if (!ret)
