Re: [PATCH] autofs-5.0.7 - fix automounter support on parisc (ARM64)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2013-03-06 at 21:59 +0100, Helge Deller wrote:
> On 03/06/2013 09:49 PM, Helge Deller wrote:
> > The patch consists of two parts: Part 1 adds code to detect a 64bit
> > parisc kernel (uname reports "parisc64").
> > [...]
> > 
> > diff -up ./daemon/automount.c.org ./daemon/automount.c
> > --- ./daemon/automount.c.org	2013-03-06 18:09:10.000000000 +0100
> > +++ ./daemon/automount.c	2013-03-06 18:09:31.000000000 +0100
> > @@ -610,6 +610,7 @@ static size_t get_kpkt_len(void)
> >  		if (strcmp(un.machine, "alpha") == 0 ||
> >  		    strcmp(un.machine, "ia64") == 0 ||
> >  		    strcmp(un.machine, "x86_64") == 0 ||
> > +		    strcmp(un.machine, "parisc64") == 0 ||
> >  		    strcmp(un.machine, "ppc64") == 0)

OK, I'll add that anyway.

> 
> I assume that an additional:
> 	strcmp(un.machine, "aarch64") == 0 
> is needed for ARM64 (aarch64) as well.
> But I don't have such a hardware to test....

Not sure either.

When I originally did the analysis I came up with what we have now but
apparently that was mostly wrong anyway.

The mistake I originally made was the total structure length no being a
multiple of 8, the internal structure alignment was ok. So if the
hardware aligns structures on 64bit boundaries there's a problem, but if
structure alignment is 32bits there isn't.

That's only needed for older kernels anyway, since there was a kernel
change, somewhere around 3.5 or so, to make these tests redundant.

> 
> Helge
> 


--
To unsubscribe from this list: send the line "unsubscribe autofs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux Ext4]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux