Am 06.12.2010 13:43, schrieb Tom Gundersen: > On Mon, Dec 6, 2010 at 12:04 PM, Thomas Bächler <thomas@xxxxxxxxxxxxx> wrote: >> https://github.com/teg/initscripts-arch/commit/b4c804d60d6e8361db3f19bf3a2fa6fb58ee8458 >> >> Two short comments about this commit: >> >> 1) We need to run vgchange again after rw-mounting everything (without >> --sysinit), so monitoring can be set up. >> 2) mkinitcpio's LVM hook also needs --sysinit. >> >> The rest of the patches are fine. > > Thanks to Thomas and Dave for fast feedback. I pushed a few more > commits to my trees to address their comments: > > <https://github.com/teg/initscripts-arch/> > <https://github.com/teg/mkinitcpio/> Thanks. The initscripts patch won't work though: [[ $USELVM =~ yes|YES && -x /sbin/lvm && -d /sys/block ]] || return "return" is a statement that will only work inside a function. I don't know what it will do on the top level, but certainly not what you'd expect. > Finally, here is a patch for mkinitcpio's LVM hook (don't know if this > is the best way to contribute to svn repo's...): > > > --- lvm2_hook 2010-12-06 13:20:10.588544437 +0100 > +++ lvm2_hook 2010-12-06 13:25:22.838755236 +0100 > @@ -20,6 +20,6 @@ > msg "Scanning logical volumes..." > eval /sbin/lvm vgscan --ignorelockingfailure $LVMQUIET > msg "Activating logical volumes..." > - eval /sbin/lvm vgchange --ignorelockingfailure > --ignoremonitoring -ay $LVMQUIET > + eval /sbin/vgchange --sysinit -a y $LVMQUIET > fi > } > Heh, there is no good way, sadly.
Attachment:
signature.asc
Description: OpenPGP digital signature
