Re: [PATCH 01/48] Bashification of initscripts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



Am 01.07.2010 00:07, schrieb Victor Lowther:
> On Wed, 2010-06-30 at 23:55 +0200, Thomas Bächler wrote:
>> Am 30.06.2010 23:47, schrieb Victor Lowther:
>>> Despite efforts to make the initscripts POSIX, we use bash 4.0 features.
>>>
>>> Bashifying this framework should result in about a 30% speedup, assuming no
>>> IO latency and that all programs we call also take zero time. :)
>>> ---
>>>  functions |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/functions b/functions
>>> index 672eed2..023de35 100644
>>> --- a/functions
>>> +++ b/functions
>>> @@ -1,4 +1,4 @@
>>> -#
>>> +#!/bin/bash
>>>  # initscripts functions
>>
>> I don't see the need for this patch. functions is not supposed to be
>> executed standalone, it is only source'd from bash scripts.
> 
> It is a habit I have -- including the shebang line at the top makes sure
> my text editors automatically detect the right shell syntax for syntax
> highlighting.
> 

Fair enough, but then that should be in the commit message.

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux