Re: [PATCH 30/48] bashify bringing up the loopback adaptor.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Thu, 2010-07-01 at 00:13 +0200, Thomas Bächler wrote:
> Am 30.06.2010 23:47, schrieb Victor Lowther:
> > ---
> >  rc.sysinit |    9 ++++-----
> >  1 files changed, 4 insertions(+), 5 deletions(-)
> > 
> > diff --git a/rc.sysinit b/rc.sysinit
> > index 1d16224..31636e5 100755
> > --- a/rc.sysinit
> > +++ b/rc.sysinit
> > @@ -113,13 +113,12 @@ fi
> >  run_hook sysinit_udevsettled
> >  
> >  # bring up the loopback interface
> > -if [ -d /sys/class/net/lo ]; then
> > +if [[ -d /sys/class/net/lo ]]; then
> >  	stat_busy "Bringing up loopback interface"
> > -	/sbin/ifconfig lo 127.0.0.1 up
> > -	if [ $? -ne 0 ]; then
> > -		stat_fail
> > +	if ! /sbin/ifconfig lo 127.0.0.1 up; then
> > +	    stat_fail
> >  	else
> > -		stat_done
> > +	    stat_done
> >  	fi
> >  fi
> >  
> 
> Hmm, this could be done with the status() function instead, right? No
> need for stat_{busy,fail,done} then.

Probably.  I was just looking for trivial bashification here -- I did
not look for further simplifications.


-- 
Victor Lowther
LPIC2 UCP RHCE 


[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux