On Tue, Dec 15, 2009 at 3:42 PM, Giovanni Scafora <giovanni@xxxxxxxxxxxxx> wrote: > 2009/12/15, Thomas Bächler <thomas@xxxxxxxxxxxxx>: >> Indeed. > > OK, I just fixed FS10959 and FS14083. > I hope that works. > Let me know. > Thanks, almost :) You made one other change : you commented out governor by default in the config. Then starting cpufreq daemon with default settings does this : ... cpufreq-set: option requires an argument -- 'g' <snip whole cpufreq help> That is because the following test does not work correctly : if [ -n $governor ]; then So that branch is executed anyway, even though governor is not set, and cpufreq-set is called with invalid parameter. Adding quotes to the test seems to work : if [ -n "$governor" ]; then So the result with default config will be instead : :: Setting cpufreq governing rules [BUSY] :: Invalid configuration in /etc/conf./cpufreq [FAIL] Other than that, it looks fine.
