Re: Question about identify device ATA command in vblade

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Note that the block aoe client driver doesn't give us any insight to this as it just has the following when setting up for an ATA ID command:


    /* set up ata header */
    ah->scnt = 1;
    ah->cmdstat = ATA_CMD_ID_ATA;
    ah->lba3 = 0xa0;


No comments on why scnt is set to 1 and further why lba3 is set to 0xa0, which I don't do either (one of my code review comments always highlights code like this with raw "magic" numbers and no comment as to why.. but I get that this is open source... ).

David


------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
_______________________________________________
Aoetools-discuss mailing list
Aoetools-discuss@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/aoetools-discuss

[Index of Archives]     [Linux ARM Kernel]     [Linux SCSI]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux