Re: [PATCH] drm/amdgpu: add missing NULL check

[Samuel Pitoiset <samuel.pitoiset@xxxxxxxxx>]

I can confirm this patch fixes the kernel crash I reported.

But as discussed with Christian, we should find the root cause.

On 10/6/23 14:11, Christian König wrote:
> bo->tbo.resource can easily be NULL here.
>
> Signed-off-by: Christian König <christian.koenig@xxxxxxx>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.h
> index f3ee83cdf97e..d28e21baef16 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.h
> @@ -252,7 +252,7 @@ static inline bool amdgpu_bo_in_cpu_visible_vram(struct amdgpu_bo *bo)
>   	struct amdgpu_device *adev = amdgpu_ttm_adev(bo->tbo.bdev);
>   	struct amdgpu_res_cursor cursor;
>   
> -	if (bo->tbo.resource->mem_type != TTM_PL_VRAM)
> +	if (!bo->tbo.resource || bo->tbo.resource->mem_type != TTM_PL_VRAM)
>   		return false;
>   
>   	amdgpu_res_first(bo->tbo.resource, 0, amdgpu_bo_size(bo), &cursor);