Re: [PATCH AUTOSEL 5.10 13/22] drm/amdgpu: install stub fence into potential unused fence pointers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 07.10.23 um 11:50 schrieb Greg KH:
On Sun, Sep 10, 2023 at 03:43:01PM -0500, Bryan Jennings wrote:
This is also causing log spam on 5.15.  It was included in 5.15.128 as
commit 4921792e04f2125b5eadef9dbe9417a8354c7eff.  I encountered this and
found https://gitlab.freedesktop.org/drm/amd/-/issues/2820 while researching
the problem.
Confused, what should we do here?

If this patch was backported to even more older kernels then please revert that immediately!

This patch was part of a new feature and can only work correctly with a bunch of prerequisites. If you don't have those prerequisites in your branch then it might actually cause random memory corruptions through device DMA.

And we should probably talk about why this patch was automatically selected for backporting in the first place? There is no mention that this is a fix or should be backported in the commit message or patch itself whatsoever.

Without the WARN_ON() which started to spam the logs that could have gone south pretty quickly. Random data corruption without any indicator what's causing it is not really funny.

Regards,
Christian.



[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux