Thanks for your comments, Alex and Michel. So like Lijo suggested, Does dev_dbg instead of dev_info for those message printings make sense to you as well? Regards, Guchun -----Original Message----- From: Alex Deucher <alexdeucher@xxxxxxxxx> Sent: Wednesday, November 23, 2022 11:41 PM To: Michel Dänzer <michel.daenzer@xxxxxxxxxxx> Cc: Chen, Guchun <Guchun.Chen@xxxxxxx>; Lazar, Lijo <Lijo.Lazar@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Zhang, Hawking <Hawking.Zhang@xxxxxxx>; Quan, Evan <Evan.Quan@xxxxxxx> Subject: Re: [PATCH 3/3] drm/amdgpu: add printing to indicate rpm completeness On Wed, Nov 23, 2022 at 8:58 AM Michel Dänzer <michel.daenzer@xxxxxxxxxxx> wrote: > > On 11/23/22 07:09, Chen, Guchun wrote: > > Hi Lijo, > > > > Thanks for your review. The cause for this change is, so far, except one line printing like "amdgpu: free PSP TMR buffer", there are no other printings once system completes rpm suspend. And moreover, "free PSP TMR buffer" sometimes confuses audiences. > > How about making those messages not printed by default then, instead of adding more? Yeah, I agree. No need to add more. Runtime PM can happen pretty frequently. Alex > > > -- > Earthling Michel Dänzer | https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fredhat.com%2F&data=05%7C01%7CGuchun.Chen%40amd.com%7C4669eec9570e4afc1e3d08dacd692ad7%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638048148815933075%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=vu7ZbIwuFX3PFIjvQgoQAqoVqCO02Moxzk%2Br8ubK23U%3D&reserved=0 > Libre software enthusiast | Mesa and Xwayland developer >
<<attachment: winmail.dat>>
