Hi Lijo, Thanks for your review. The cause for this change is, so far, except one line printing like "amdgpu: free PSP TMR buffer", there are no other printings once system completes rpm suspend. And moreover, "free PSP TMR buffer" sometimes confuses audiences. Regards, Guchun -----Original Message----- From: Lazar, Lijo <Lijo.Lazar@xxxxxxx> Sent: Wednesday, November 23, 2022 1:58 PM To: Chen, Guchun <Guchun.Chen@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Zhang, Hawking <Hawking.Zhang@xxxxxxx>; Quan, Evan <Evan.Quan@xxxxxxx> Subject: Re: [PATCH 3/3] drm/amdgpu: add printing to indicate rpm completeness On 11/23/2022 7:14 AM, Guchun Chen wrote: > Add an explicit printing to tell when finishing rpm execution in > amdgpu. > > Signed-off-by: Guchun Chen <guchun.chen@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > index bf2d50c8c92a..fa42c0fcf848 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > @@ -2572,6 +2572,8 @@ static int amdgpu_pmops_runtime_suspend(struct device *dev) > amdgpu_device_baco_enter(drm_dev); > } > > + dev_info(&pdev->dev, "amdgpu finishes runtime suspend\n"); > + This may be an annoyance. Maybe dev_dbg? Series is: Reviewed-by: Lijo Lazar <lijo.lazar@xxxxxxx> Thanks, Lijo > return 0; > } >
<<attachment: winmail.dat>>
