Re: [PATCH 1/1] drm/amdgpu: Free user pages if kvmalloc_array fails

[Christian König <ckoenig.leichtzumerken@xxxxxxxxx>]

Am 29.04.22 um 02:29 schrieb Philip Yang:
> To cleanup the BOs of bo_list which have got user pages.
>
> Signed-off-by: Philip Yang <Philip.Yang@xxxxxxx>

Reviewed-by: Christian König <christian.koenig@xxxxxxx>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> index 44dcbef80229..ccde951244f5 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -543,7 +543,8 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p,
>   					GFP_KERNEL | __GFP_ZERO);
>   		if (!e->user_pages) {
>   			DRM_ERROR("kvmalloc_array failure\n");
> -			return -ENOMEM;
> +			r = -ENOMEM;
> +			goto out_free_user_pages;
>   		}
>   
>   		r = amdgpu_ttm_tt_get_user_pages(bo, e->user_pages);