On 3/23/2022 2:22 PM, Paul Menzel wrote: > Dear Jun, > > > Thank you for your patch. > > Am 23.03.22 um 04:02 schrieb Ma, Jun: > >> On 3/22/2022 9:33 PM, Christian König wrote: >>> Am 22.03.22 um 13:53 schrieb Ma Jun: >>>> Correct the parameter name of amdgpu_ring_init() in header file. >>> >>> Maybe write "Sync up header and implementation to use the same parameter >>> names", otherwise somebody could think that this is a real functional >>> bug fix and backport it. >>> ok, will fix this in v2 > > (Your mailer incorrectly quoted your reply sentence, making it look like > it was written by Christian.) > > If you re-roll the patch, please also mention both parameter names in > the commit message, so people do not have to search in the diff for > them, and can verify the changes match your intention. (The summary uses > singular *name* adding a little confusion.) > Good suggestion, thank you. Regards, Ma Jun > > Kind regards, > > Paul > > >>>> Signed-off-by: Ma Jun <Jun.Ma2@xxxxxxx> >>> >>> With the commit message and subject adjusted the patch is Reviewed-by: >>> Christian König <christian.koenig@xxxxxxx> >>> >>>> Change-Id: I202d76ba04b137926b456b1c8a4c05a5b1a01bff >>>> --- >>>> drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h >>>> index 5320bb0883d8..317d80209e95 100644 >>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h >>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h >>>> @@ -300,8 +300,8 @@ void amdgpu_ring_generic_pad_ib(struct amdgpu_ring *ring, struct amdgpu_ib *ib); >>>> void amdgpu_ring_commit(struct amdgpu_ring *ring); >>>> void amdgpu_ring_undo(struct amdgpu_ring *ring); >>>> int amdgpu_ring_init(struct amdgpu_device *adev, struct amdgpu_ring *ring, >>>> - unsigned int ring_size, struct amdgpu_irq_src *irq_src, >>>> - unsigned int irq_type, unsigned int prio, >>>> + unsigned int max_dw, struct amdgpu_irq_src *irq_src, >>>> + unsigned int irq_type, unsigned int hw_prio, >>>> atomic_t *sched_score); >>>> void amdgpu_ring_fini(struct amdgpu_ring *ring); >>>> void amdgpu_ring_emit_reg_write_reg_wait_helper(struct amdgpu_ring *ring, >>>
