|
[Public] Sorry for missing RB. This patch is: Reviewed-by: Guchun Chen <guchun.chen@xxxxxxx> Regards, Guchun From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx>
On Behalf Of Chen, Guchun [Public] Thanks John. As in the same context, it’s meaningless that two mutex target almost the same thing. Regards, Guchun From: Clements, John <John.Clements@xxxxxxx>
[Public] Based off your feedback I double checked the code, and I changed my opinion about it, I think it’s better just to reuse the original mutex for now. I’ve submitted an updated patch for review From: Clements, John <John.Clements@xxxxxxx>
Hello Guchun, In most of those cases you are right it is redundant, the reason i kept them separate for now is to resolve this bug while also keeping those interfaces modular, and not
affecting the psp submit sequence yet. We are planning a bigger change to that source to remove alot of the duplicate code regarding the cmd buffer prepare/submit flow and will probably go back down to one mutex there. Thank you,
John Clements From: Chen, Guchun <Guchun.Chen@xxxxxxx> [Public] Before calling into psp_cmd_submit_buf, a mutex psp->cmd_buf_mutex is there, and after entering psp_cmd_submit_buf, there is another mutex psp->mutex, is it a bit redundant? Regards, Guchun From: Clements, John <John.Clements@xxxxxxx>
[AMD Official Use Only] Submitting patch to synchronize access to psp cmd submission memory to resolve potential race conditions. |
