RE: [PATCH] drm/amdgpu: don't enable baco on boco platforms in runpm

["Quan, Evan" <Evan.Quan@xxxxxxx>]

[AMD Official Use Only]

Reviewed-by: Evan Quan <evan.quan@xxxxxxx>

> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Alex
> Deucher
> Sent: Tuesday, August 3, 2021 12:46 AM
> To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>
> Subject: [PATCH] drm/amdgpu: don't enable baco on boco platforms in
> runpm
> 
> If the platform uses BOCO, don't use BACO in runtime suspend.
> We could end up executing the BACO path if the platform supports both.
> 
> Bug:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitla
> b.freedesktop.org%2Fdrm%2Famd%2F-
> %2Fissues%2F1669&amp;data=04%7C01%7Cevan.quan%40amd.com%7Cd65
> c86a3b85b452e049708d955d4fe72%7C3dd8961fe4884e608e11a82d994e183d
> %7C0%7C0%7C637635195555369506%7CUnknown%7CTWFpbGZsb3d8eyJWIj
> oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1
> 000&amp;sdata=7eXhQgYtlr6ek%2BNtuLQyrCKvyGCePctiD0cKlFjsIhw%3D&a
> mp;reserved=0
> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 91a5ed96bfbe..d96aaa2aa5ba 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -1566,6 +1566,8 @@ static int amdgpu_pmops_runtime_suspend(struct
> device *dev)
>  		pci_ignore_hotplug(pdev);
>  		pci_set_power_state(pdev, PCI_D3cold);
>  		drm_dev->switch_power_state =
> DRM_SWITCH_POWER_DYNAMIC_OFF;
> +	} else if (amdgpu_device_supports_boco(drm_dev)) {
> +		/* nothing to do */
>  	} else if (amdgpu_device_supports_baco(drm_dev)) {
>  		amdgpu_device_baco_enter(drm_dev);
>  	}
> --
> 2.31.1