Re: [PATCH] This patch replaces all the instances of dev_info with drm_info macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Aman,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.13-rc7 next-20210621]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Aman-Jain/This-patch-replaces-all-the-instances-of-dev_info-with-drm_info-macro/20210622-140850
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a96bfed64c8986d6404e553f18203cae1f5ac7e6
config: ia64-randconfig-r005-20210622 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/aa0d692308d703f641f19def814f7c8d59468671
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Aman-Jain/This-patch-replaces-all-the-instances-of-dev_info-with-drm_info-macro/20210622-140850
        git checkout aa0d692308d703f641f19def814f7c8d59468671
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   In file included from include/linux/device.h:15,
                    from include/linux/pm_runtime.h:11,
                    from drivers/gpu/drm/radeon/radeon_drv.c:36:
   drivers/gpu/drm/radeon/radeon_drv.c: In function 'radeon_pci_probe':
>> include/drm/drm_print.h:412:27: error: 'struct device' has no member named 'dev'; did you mean 'devt'?
     412 |  dev_##level##type((drm)->dev, "[drm] " fmt, ##__VA_ARGS__)
         |                           ^~~
   include/linux/dev_printk.h:118:12: note: in definition of macro 'dev_info'
     118 |  _dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |            ^~~
   include/drm/drm_print.h:416:2: note: in expansion of macro '__drm_printk'
     416 |  __drm_printk((drm), info,, fmt, ##__VA_ARGS__)
         |  ^~~~~~~~~~~~
   drivers/gpu/drm/radeon/radeon_drv.c:311:4: note: in expansion of macro 'drm_info'
     311 |    drm_info(&pdev->dev,
         |    ^~~~~~~~
>> include/drm/drm_print.h:412:27: error: 'struct device' has no member named 'dev'; did you mean 'devt'?
     412 |  dev_##level##type((drm)->dev, "[drm] " fmt, ##__VA_ARGS__)
         |                           ^~~
   include/linux/dev_printk.h:118:12: note: in definition of macro 'dev_info'
     118 |  _dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |            ^~~
   include/drm/drm_print.h:416:2: note: in expansion of macro '__drm_printk'
     416 |  __drm_printk((drm), info,, fmt, ##__VA_ARGS__)
         |  ^~~~~~~~~~~~
   drivers/gpu/drm/radeon/radeon_drv.c:323:4: note: in expansion of macro 'drm_info'
     323 |    drm_info(&pdev->dev,
         |    ^~~~~~~~


vim +412 include/drm/drm_print.h

02c9656b2f0d69 Haneen Mohammed       2017-10-17  378  
02c9656b2f0d69 Haneen Mohammed       2017-10-17  379  /**
b52817e9de06a3 Mauro Carvalho Chehab 2020-10-27  380   * DRM_DEV_DEBUG() - Debug output for generic drm code
02c9656b2f0d69 Haneen Mohammed       2017-10-17  381   *
091756bbb1a961 Haneen Mohammed       2017-10-17  382   * @dev: device pointer
091756bbb1a961 Haneen Mohammed       2017-10-17  383   * @fmt: printf() like format string.
02c9656b2f0d69 Haneen Mohammed       2017-10-17  384   */
db87086492581c Joe Perches           2018-03-16  385  #define DRM_DEV_DEBUG(dev, fmt, ...)					\
db87086492581c Joe Perches           2018-03-16  386  	drm_dev_dbg(dev, DRM_UT_CORE, fmt, ##__VA_ARGS__)
b52817e9de06a3 Mauro Carvalho Chehab 2020-10-27  387  /**
b52817e9de06a3 Mauro Carvalho Chehab 2020-10-27  388   * DRM_DEV_DEBUG_DRIVER() - Debug output for vendor specific part of the driver
b52817e9de06a3 Mauro Carvalho Chehab 2020-10-27  389   *
b52817e9de06a3 Mauro Carvalho Chehab 2020-10-27  390   * @dev: device pointer
b52817e9de06a3 Mauro Carvalho Chehab 2020-10-27  391   * @fmt: printf() like format string.
b52817e9de06a3 Mauro Carvalho Chehab 2020-10-27  392   */
db87086492581c Joe Perches           2018-03-16  393  #define DRM_DEV_DEBUG_DRIVER(dev, fmt, ...)				\
db87086492581c Joe Perches           2018-03-16  394  	drm_dev_dbg(dev, DRM_UT_DRIVER,	fmt, ##__VA_ARGS__)
b52817e9de06a3 Mauro Carvalho Chehab 2020-10-27  395  /**
b52817e9de06a3 Mauro Carvalho Chehab 2020-10-27  396   * DRM_DEV_DEBUG_KMS() - Debug output for modesetting code
b52817e9de06a3 Mauro Carvalho Chehab 2020-10-27  397   *
b52817e9de06a3 Mauro Carvalho Chehab 2020-10-27  398   * @dev: device pointer
b52817e9de06a3 Mauro Carvalho Chehab 2020-10-27  399   * @fmt: printf() like format string.
b52817e9de06a3 Mauro Carvalho Chehab 2020-10-27  400   */
db87086492581c Joe Perches           2018-03-16  401  #define DRM_DEV_DEBUG_KMS(dev, fmt, ...)				\
db87086492581c Joe Perches           2018-03-16  402  	drm_dev_dbg(dev, DRM_UT_KMS, fmt, ##__VA_ARGS__)
a18b21929453af Lyude Paul            2018-07-16  403  
fb6c7ab8718eb2 Jani Nikula           2019-12-10  404  /*
fb6c7ab8718eb2 Jani Nikula           2019-12-10  405   * struct drm_device based logging
fb6c7ab8718eb2 Jani Nikula           2019-12-10  406   *
fb6c7ab8718eb2 Jani Nikula           2019-12-10  407   * Prefer drm_device based logging over device or prink based logging.
fb6c7ab8718eb2 Jani Nikula           2019-12-10  408   */
fb6c7ab8718eb2 Jani Nikula           2019-12-10  409  
fb6c7ab8718eb2 Jani Nikula           2019-12-10  410  /* Helper for struct drm_device based logging. */
fb6c7ab8718eb2 Jani Nikula           2019-12-10  411  #define __drm_printk(drm, level, type, fmt, ...)			\
fb6c7ab8718eb2 Jani Nikula           2019-12-10 @412  	dev_##level##type((drm)->dev, "[drm] " fmt, ##__VA_ARGS__)
fb6c7ab8718eb2 Jani Nikula           2019-12-10  413  
fb6c7ab8718eb2 Jani Nikula           2019-12-10  414  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux