Am 22.06.21 um 08:07 schrieb Aman Jain:
When a driver has multiple instances it is necessary to differentiate between them in the logs. This was done with dev_info/warn/err since DRM_INFO/WARN/ERROR don't do this. We now have drm_info/warn/err for printing the relevant debug messages. Hence, this patch uses drm_* macros to achieve drm-formatted logging
Well first of all patches for radeon should have a drm/radeon prefix in its subject line.
Then I don't think this patch makes sense since this is about the hardware support of the module and not even remotely drm related.
So we most likely don't want the drm-formating here in the first place. Regards, Christian.
Signed-off-by: Aman Jain <ahjain2706@xxxxxxxxx> --- drivers/gpu/drm/radeon/radeon_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c index efeb115ae70e..75e84914c29b 100644 --- a/drivers/gpu/drm/radeon/radeon_drv.c +++ b/drivers/gpu/drm/radeon/radeon_drv.c @@ -308,7 +308,7 @@ static int radeon_pci_probe(struct pci_dev *pdev, case CHIP_VERDE: case CHIP_OLAND: case CHIP_HAINAN: - dev_info(&pdev->dev, + drm_info(&pdev->dev, "SI support disabled by module param\n"); return -ENODEV; } @@ -320,7 +320,7 @@ static int radeon_pci_probe(struct pci_dev *pdev, case CHIP_HAWAII: case CHIP_KABINI: case CHIP_MULLINS: - dev_info(&pdev->dev, + drm_info(&pdev->dev, "CIK support disabled by module param\n"); return -ENODEV; }
_______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
