Re: Re: [PATCH] drm/amdgpu: add the missing AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS flag

["Chen Lei" <chenlei18s@xxxxxxxxx>]

Hi! I am not quite familiar with it, and I was wondering why this flag is blocked. As the VM subsystem supports giant pages, it might be useful to add this flag in amdgpu_gem_create_ioctl. 


> -----原始邮件-----
&gt; 发件人: "Christian König" <ckoenig.leichtzumerken@xxxxxxxxx>
&gt; 发送时间: 2020-12-08 15:41:02 (星期二)
&gt; 收件人: "Chen Lei" <chenlei18s@xxxxxxxxx>, alexander.deucher@xxxxxxx, christian.koenig@xxxxxxx
&gt; 抄送: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
&gt; 主题: Re: [PATCH] drm/amdgpu: add the missing AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS flag
&gt; 
&gt; Am 08.12.20 um 03:50 schrieb Chen Lei:
&gt; &gt; Add the AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS flag in amdgpu_gem_create_ioctl.
&gt; &gt;
&gt; &gt; Signed-off-by: Chen Lei <chenlei18s@xxxxxxxxx>
&gt; 
&gt; NAK, that is not missing but intentionally blocked.
&gt; 
&gt; Christian.
&gt; 
&gt; &gt; ---
&gt; &gt;   drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 1 +
&gt; &gt;   1 file changed, 1 insertion(+)
&gt; &gt;
&gt; &gt; diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
&gt; &gt; index 7e8265da9..da18aeff7 100644
&gt; &gt; --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
&gt; &gt; +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
&gt; &gt; @@ -233,6 +233,7 @@ int amdgpu_gem_create_ioctl(struct drm_device *dev, void *data,
&gt; &gt;   		      AMDGPU_GEM_CREATE_NO_CPU_ACCESS |
&gt; &gt;   		      AMDGPU_GEM_CREATE_CPU_GTT_USWC |
&gt; &gt;   		      AMDGPU_GEM_CREATE_VRAM_CLEARED |
&gt; &gt; +		      AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS |
&gt; &gt;   		      AMDGPU_GEM_CREATE_VM_ALWAYS_VALID |
&gt; &gt;   		      AMDGPU_GEM_CREATE_EXPLICIT_SYNC |
&gt; &gt;   		      AMDGPU_GEM_CREATE_ENCRYPTED))
</chenlei18s@xxxxxxxxx></chenlei18s@xxxxxxxxx></ckoenig.leichtzumerken@xxxxxxxxx>
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx