On Wed, Jul 22, 2020 at 4:25 PM Michel Dänzer <michel@xxxxxxxxxxx> wrote: > > On 2020-07-22 3:10 p.m., Kazlauskas, Nicholas wrote: > > On 2020-07-22 8:51 a.m., Daniel Vetter wrote: > >> On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer <michel@xxxxxxxxxxx> wrote: > >>> > >>> From: Michel Dänzer <mdaenzer@xxxxxxxxxx> > >>> > >>> drm_atomic_crtc_check enforces that ::active can only be true if > >>> ::enable is as well. > >>> > >>> Signed-off-by: Michel Dänzer <mdaenzer@xxxxxxxxxx> > > > > Looks fine to me. The check is sufficiently old enough that I don't mind > > relying on the core for this either. "active implies enabled" has been a hard assumption of atomic from day 1. So should work anywhere you have atomic. -Daniel > > Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@xxxxxxx> > > > >> > >> modeset vs modereset is a bit an inglorious name choice ... since this > >> seems to be glue code and not part of core dc, maybe rename to > >> enable_required/disable_required to keep it consistent with the > >> wording atomic helpers use? DC also seems to use reset for a lot of > >> other things already (state reset, like atomic, or gpu reset like > >> drm/scheduler's td_r_), so I think this would also help clarity from a > >> DC perspective. > >> > >> Patch itself is good, above just an idea for another patch on top. > >> > >> Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > > Thanks for the reviews! I assume this will get picked up by a DC > developer or Alex/Christian. > > > > That sounds like a reasonable idea to me. These are used more as a > > stream_changed / stream_removed flag, but I don't think these helpers > > really need to exist at all. > > > > That could come as a follow up patch. > > Yeah, I'm leaving that to you guys. :) > > > -- > Earthling Michel Dänzer | https://redhat.com > Libre software enthusiast | Mesa and X developer -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
