[AMD Public Use] case CHIP_ARCTURUS: + return __get_eeprom_i2c_addr_arct(adev, i2c_addr); + break; This ‘break’ is not needed. Please remove it. Regards, Guchun From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx>
On Behalf Of Zhang, Hawking [AMD Official Use Only - Internal Distribution Only] Please fix your coding style in the follow if/else code segment by removing the unnecessary {}. Other than that, the patch is Reviewed-by: Hawking Zhang <Hawking.Zhang@xxxxxxx> + if (strnstr(atom_ctx->vbios_version, + "D342", + sizeof(atom_ctx->vbios_version))) + { + *i2c_addr = EEPROM_I2C_TARGET_ADDR_ARCTURUS_D342; + } + else + { + *i2c_addr = EEPROM_I2C_TARGET_ADDR_ARCTURUS; + } Regards, From: Clements, John <John.Clements@xxxxxxx>
Add support for detecting Arcturus SKU to resolve the correct bad page retirement EEPROM I2C address. Thank you, John Clements |
_______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx