RE: [PATCH 2/2] drm/amdgpu: enable S/G display for renoir

["Deucher, Alexander" <Alexander.Deucher@xxxxxxx>]

[AMD Official Use Only - Internal Distribution Only]

> -----Original Message-----
> From: Liu, Aaron <Aaron.Liu@xxxxxxx>
> Sent: Tuesday, January 7, 2020 9:48 PM
> To: Alex Deucher <alexdeucher@xxxxxxxxx>; amd-
> gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>
> Subject: RE: [PATCH 2/2] drm/amdgpu: enable S/G display for renoir
> 
> Reviewed & Tested-by: Aaron Liu <aaron.liu@xxxxxxx>
> 

Did you test with limited vram?  E.g, set the carve out to 32 or 64 MB so the driver actually uses gart for display?

Thanks,

Alex

> BR,
> Aaron Liu
> 
> > -----Original Message-----
> > From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of
> > Alex Deucher
> > Sent: Wednesday, January 8, 2020 5:13 AM
> > To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> > Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>
> > Subject: [PATCH 2/2] drm/amdgpu: enable S/G display for renoir
> >
> > Everything is in place so go ahead and enable this for renoir.
> >
> > Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
> > ---
> >
> > I don't have a renoir board handy.  Can someone test this?
> >
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_display.c       | 1 +
> >  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 +
> >  2 files changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> > b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> > index 6d520a3eec40..318605ca9bc3 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> > @@ -519,6 +519,7 @@ uint32_t
> amdgpu_display_supported_domains(struct
> > amdgpu_device *adev,
> >  		switch (adev->asic_type) {
> >  		case CHIP_CARRIZO:
> >  		case CHIP_STONEY:
> > +		case CHIP_RENOIR:
> >  			domain |= AMDGPU_GEM_DOMAIN_GTT;
> >  			break;
> >  		case CHIP_RAVEN:
> > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > index 05118c8860f9..3be7ab0ce9e3 100644
> > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > @@ -909,6 +909,7 @@ static int amdgpu_dm_init(struct amdgpu_device
> > *adev)
> >  	switch (adev->asic_type) {
> >  	case CHIP_CARRIZO:
> >  	case CHIP_STONEY:
> > +	case CHIP_RENOIR:
> >  		init_data.flags.gpu_vm_support = true;
> >  		break;
> >  	case CHIP_RAVEN:
> > --
> > 2.24.1
> >
> > _______________________________________________
> > amd-gfx mailing list
> > amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
> > s.f
> > reedesktop.org%2Fmailman%2Flistinfo%2Famd-
> >
> gfx&amp;data=02%7C01%7Caaron.liu%40amd.com%7Cd9cdd08e60a942e97c
> > 6a08d793b67ea1%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6
> >
> 37140284454500549&amp;sdata=TGuS5qqX8siW1sxWUZtQggnk4P2RPjxUiLk
> > dvS1Fcog%3D&amp;reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx