|
[AMD Public Use] Hello GuChun/Tao, Thank you for your feedback, I have implemented both of your changes. Thank you, John Clements From: Chen, Guchun <Guchun.Chen@xxxxxxx> [AMD Public Use] If we have to improve the macro definition for repetitive loops, I assume we can merge the two defines into one, like: #define LOOP_UMC_CH_INST(umc_inst) for ((umc_inst) = 0; (umc_inst) < adev->umc.umc_inst##_num; (umc_inst)++) Then when we call the double loop, it can be done like: LOOP_UMC_CH_INST(umc_inst) LOOP_UMC_CH_INST(channel_inst) {… Next we should name the macro more friendly. Regards, Guchun From: Clements, John <John.Clements@xxxxxxx>
[AMD Official Use Only - Internal Distribution Only] Resolved issue with inputting an incorrect UMC channel index into the UMC error address record. Defined macros for repetitive for loops Thank you, John Clements |
Attachment:
0001-drm-amdgpu-updated-UMC-error-address-record-with-cor.patch
Description: 0001-drm-amdgpu-updated-UMC-error-address-record-with-cor.patch
_______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
