I prefer to calc channel_index like this:
channel_index =
adev->umc.channel_idx_tbl[umc_inst * adapt->umc.channel_inst_num + ch_inst];
idx_tbl is ASIC specific,
using adev->umc.channel_idx_tbl instead can avoid adding "if (adev->asic_type == xxx)" in the future.
Regards,
Tao
From: Clements, John <John.Clements@xxxxxxx>
Sent: Tuesday, January 7, 2020 3:28 PM To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>; dl.srdc_lnx_ras <dl.srdc_lnx_ras@xxxxxxx> Subject: [PATCH] drm/amdgpu: updated UMC error address record with correct channel index [AMD Official Use Only - Internal Distribution Only] Resolved issue with inputting an incorrect UMC channel index into the UMC error address record.
Defined macros for repetitive for loops
Thank you, John Clements |
_______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx